Java Environment Variable Bindings #740
Conversation
Added the bindings for MPI_GET_VERSION and MPI_GET_LIBRARY_VERSION. Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
There was a problem hiding this comment.
Minor comment: Seems like weird indenting...?
There was a problem hiding this comment.
It is weird indenting, but I believe it follows the indenting of the rest of the java files. If you like I can easily change it.
There was a problem hiding this comment.
I could also fix the indenting for all of the other Java files if you
like. Its very very simple in eclipse.
On Thu, Jul 23, 2015 at 3:03 PM, Jeff Squyres notifications@github.com
wrote:
In ompi/mpi/java/java/Version.java
#740 (comment):
- * File : Version.java
- * Author : Nathaniel Graham
- * Created : Thu Jul 23 09:25 2015
- /
+
+package mpi;
+
+/*- * Version and Subversion for MPI
- */
+public final class Version
+{
+private final int version;
+private final int subVersion;Minor comment: Seems like weird indenting...?
—
Reply to this email directly or view it on GitHub
https://github.com/open-mpi/ompi/pull/740/files#r35371038.
There was a problem hiding this comment.
What's the "Normal" Java way? To my C-trained eye, this looks weird. But if it's The Way Java People Do It, it's fine.
If it's not the normal way java people do it, then you might as well keep the indenting here in this PR and make a separate PR for just all the whitespace/indenting changes. Cool?
There was a problem hiding this comment.
This is not the normal way. The normal way indents everything inside the class as well. I will fix the indentation in a separate PR.
|
Looks like mlnx jenkins is getting timeouts again on some of its multi-threaded bw tests. |
|
👍 |
Java Environment Variable Bindings
btl/openib: fix access flags
3 participants
Added the bindings for MPI_GET_VERSION and MPI_GET_LIBRARY_VERSION.
Signed-off-by: Nathaniel Graham ngraham@lanl.gov
@hppritcha @jsquyres