-
Notifications
You must be signed in to change notification settings - Fork 930
Java Environment Variable Bindings #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hppritcha
merged 1 commit into
open-mpi:master
from
nrgraham23:environment_java_bindings
Jul 24, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Copyright (c) 2015 Los Alamos National Security, LLC. All rights | ||
| * reserved. | ||
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow | ||
| * | ||
| * $HEADER$ | ||
| * | ||
| * | ||
| * This file is almost a complete re-write for Open MPI compared to the | ||
| * original mpiJava package. Its license and copyright are listed below. | ||
| * See <path to ompi/mpi/java/README> for more information. | ||
| * | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * | ||
| * File : Version.java | ||
| * Author : Nathaniel Graham | ||
| * Created : Thu Jul 23 09:25 2015 | ||
| */ | ||
|
|
||
| package mpi; | ||
|
|
||
| /** | ||
| * Version and Subversion for MPI | ||
| */ | ||
| public final class Version | ||
| { | ||
| private final int version; | ||
| private final int subVersion; | ||
|
|
||
| protected Version(int version, int subVersion) | ||
| { | ||
| this.version = version; | ||
| this.subVersion = subVersion; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the MPI version. | ||
| * @return MPI version | ||
| */ | ||
| public int getVersion() | ||
| { | ||
| return version; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the MPI subversion. | ||
| * @return MPI subversion | ||
| */ | ||
| public int getSubVersion() | ||
| { | ||
| return subVersion; | ||
| } | ||
|
|
||
| } // Version | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: Seems like weird indenting...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird indenting, but I believe it follows the indenting of the rest of the java files. If you like I can easily change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also fix the indenting for all of the other Java files if you
like. Its very very simple in eclipse.
On Thu, Jul 23, 2015 at 3:03 PM, Jeff Squyres notifications@github.com
wrote:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the "Normal" Java way? To my C-trained eye, this looks weird. But if it's The Way Java People Do It, it's fine.
If it's not the normal way java people do it, then you might as well keep the indenting here in this PR and make a separate PR for just all the whitespace/indenting changes. Cool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the normal way. The normal way indents everything inside the class as well. I will fix the indentation in a separate PR.