Skip to content

Conversation

@roblatham00
Copy link
Contributor

move opening of files from hint processing and into open routines.

This is MPICH commit 92f1c69f0de8 and 22a77dceda11

more information at https://trac.mpich.org/projects/mpich/ticket/2261
Ref: #158
closes openmpi #158
Signed-off-by: Pavan Balaji balaji@anl.gov

@goodell
Copy link
Member

goodell commented Jul 29, 2015

Hey Rob, thanks for the PR, since I know you're under no obligation to help maintain ROMIO in OMPI. I'm going to let people who actually deal with MPI-IO in OMPI look at this, but I have one minor nit:

Ref: #2261

This breadcrumb should probably be removed from the commit before it gets merged, since it refers to an MPICH Trac ticket number, not an OMPI github issue number. At some point when OMPI hits >2261 PRs/issues, this breadcrumb will potentially become confusing.

@roblatham00
Copy link
Contributor Author

In this case the motivation is more selfish than altruistic: a Darshan user
using OpenMPI couldn't create log files because of this. Editing the
breadcrumb makes sense (hope github really did edit it...), and I'll try to
remember to namespace these identifiers in the future.

On Wed, Jul 29, 2015 at 10:59 AM, Dave Goodell notifications@github.com
wrote:

Hey Rob, thanks for the PR, since I know you're under no obligation to
help maintain ROMIO in OMPI. I'm going to let people who actually deal with
MPI-IO in OMPI look at this, but I have one minor nit:

Ref: #2261

This breadcrumb should probably be removed from the commit before it gets
merged, since it refers to an MPICH Trac ticket number, not an OMPI github
issue number. At some point when OMPI hits >2261 PRs/issues, this
breadcrumb will potentially become confusing.


Reply to this email directly or view it on GitHub
#757 (comment).

@hppritcha
Copy link
Member

I'd prefer to merge this PR in after we've fixed some lustre problems in master. The problem results both in ompi io and romio components failing on all but trivial tests when using lustre. Once we get lustre working again and can double check this PR, I'm okay with merging it.

@goodell
Copy link
Member

goodell commented Jul 30, 2015

(hope github really did edit it...)

Looks like you successfully edited the PR description, but never force-pushed an updated commit with a fixed commit message.

move opening of files from hint processing and into open routines.

This is MPICH commit 92f1c69f0de8 and 22a77dceda11

see https://trac.mpich.org/projects/mpich/ticket/2261
Ref: open-mpi#158

Signed-off-by: Pavan Balaji <balaji@anl.gov>
@roblatham00 roblatham00 force-pushed the lustre-excl-open-fix branch from 1408deb to 6e9cbe3 Compare July 30, 2015 17:26
@hppritcha
Copy link
Member

I tried this out on a lustre file system now that ompi has gotten a visit from the lustre medic. Works for me.
👍

hppritcha added a commit that referenced this pull request Jul 31, 2015
hint processing should not open files
@hppritcha hppritcha merged commit 8649a9f into open-mpi:master Jul 31, 2015
jsquyres pushed a commit to jsquyres/ompi that referenced this pull request Aug 23, 2016
change -0bind-to and -bind-to to --bind-to in the manpages
@roblatham00 roblatham00 deleted the lustre-excl-open-fix branch October 8, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants