osc/sm: fix remaining coverity issues #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CID 1324870: Memory - illegal accesses (USE_AFTER_FREE) Free osc module after calling destruct on the lock. Fixes CID 1324868: Integer handling issues (OVERFLOW_BEFORE_WIDEN) Fixes CID 1324867: Integer handling issues (OVERFLOW_BEFORE_WIDEN) Explicitly cast to uint64_t to ensure the widen happens before an overflow can occur. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
hjelmn
added a commit
that referenced
this pull request
Sep 25, 2015
osc/sm: fix remaining coverity issues
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
…rbs-usnic-by-default v2.x: verbs_usnic: do not build by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CID 1324870: Memory - illegal accesses (USE_AFTER_FREE)
Free osc module after calling destruct on the lock.
Fixes CID 1324868: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Fixes CID 1324867: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Explicitly cast to uint64_t to ensure the widen happens before an overflow
can occur.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov