ci: Harden CI + Add zizmor static analysis for GH Actions#99
Merged
philipaconrad merged 1 commit intoopen-policy-agent:mainfrom Feb 24, 2026
Merged
Conversation
This commit fixes all findings from the Github Actions static analyis tool zizmor, and adds it to our pull request checks. It also changes the release commit detection workflow to use the reduced-permissions `pull_request` workflow trigger, and now skips on non-releases. It succeeds/fails only when a release commit is detected. Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
srenatus
approved these changes
Feb 24, 2026
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
Also updating the actions! Nice, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why?
This commit fixes all findings from the Github Actions static analysis tool
zizmor, and adds it to our pull request checks.It also changes the release commit detection workflow to use the reduced-permissions
pull_requestworkflow trigger, and now skips on non-releases. It succeeds/fails only when a release commit is detected.Unfortunately, due to the
pull_request_targetalready being set up onmain, that version of the workflow is what will run on this PR, so we can't test the new reduced-permissions version until it's merged (breaking the "upstream only" behavior). 🙁Definition of done
Do release commits get detected / handled correctly in the detection workflow?Skip: Normal PR, no release commit.Fail: Release commit, version mismatches.Pass: Release commit, versions all match.How to test
For testing release workflow:Skip: tested by the base state of this PR.Fail: Push release commit to the PR branch with version mismatch.Pass: Push release commit to the PR branch with all versions matched.Related Resources