feat(cli): promote expose/ports to top-level (keep shared aliases) - #117
Merged
Conversation
Finish the long-standing fix/expose-toplevel work: `devstack expose` and `devstack ports` are now top-level commands (the canonical spelling), while `devstack shared expose` / `shared ports` remain as backward-compatible aliases (fresh instances of the same commands). Renames the constructors newSharedExposeCmd/newSharedPortsCmd → newExposeCmd/newPortsCmd. - root.go registers top-level expose/ports; shared.go keeps the aliases. - expose_test.go asserts both paths resolve + the --off flag. - guide notes updated (no longer "mid-refactor"). make ci + determinism green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the long-pending
fix/expose-toplevelwork.devstack exposeanddevstack portsare now top-level commands (canonical), withdevstack shared expose/shared portskept as backward-compatible aliases (same logic, fresh command instances).newSharedExposeCmd/newSharedPortsCmd→newExposeCmd/newPortsCmd.root.goregisters the top-level pair;shared.gokeeps the aliases.expose_test.goasserts all four paths (expose,ports,shared expose,shared ports) resolve and--offis present.Non-breaking.
make ci(fmt/vet/build/test-race) +make determinismgreen. The incomplete stashed WIP that never compiled is superseded and dropped.🤖 Generated with Claude Code