Skip to content

Add zPages Tracez Processor#164

Merged
reyang merged 23 commits intoopen-telemetry:masterfrom
kmanghat:zpages-tracez-spanprocessor
Jul 16, 2020
Merged

Add zPages Tracez Processor#164
reyang merged 23 commits intoopen-telemetry:masterfrom
kmanghat:zpages-tracez-spanprocessor

Conversation

@jajanet
Copy link
Contributor

@jajanet jajanet commented Jul 8, 2020

This PR is for the TraceZ span processor, which will interface with a TracerProvider/Tracer on the user end to send spans to the TraceZ aggregator and later TraceZ HTTP server. This will help us eventually provide an easy way for users to see tracing information for debugging application issues (like deadlocks and high latency) without needing third party tracing systems. See the README and design doc

Files include:

  1. Processor code with added methods relevant to TraceZ for zPages. This includes storing and providing getters for running/newly completed spans (completed spans that haven't been sent before). Received spans/recordables are casted as span_data. The aggregator will regularly call the processor to minimize potential issues with memory from storing spans.
  2. Comprehensive tests for the functionality described above in different scenarios, including when completed spans may want to be stored cumulatively or non-cumulatively and different timing of spans.
  3. Bazel and CMake build files

Future PRs for TraceZ will be for its data aggregator and HTTP server

@jajanet jajanet requested a review from a team July 8, 2020 22:19
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #164 into master will increase coverage by 0.57%.
The diff coverage is 99.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   94.88%   95.45%   +0.57%     
==========================================
  Files          84       87       +3     
  Lines        2171     2488     +317     
==========================================
+ Hits         2060     2375     +315     
- Misses        111      113       +2     
Impacted Files Coverage Δ
ext/test/zpages/tracez_processor_test.cc 99.30% <99.30%> (ø)
...nclude/opentelemetry/ext/zpages/tracez_processor.h 100.00% <100.00%> (ø)
ext/src/zpages/tracez_processor.cc 100.00% <100.00%> (ø)

@jajanet jajanet changed the title WIP: zPages Tracez Processor zPages Tracez Processor Jul 9, 2020
@jajanet jajanet changed the title zPages Tracez Processor Add zPages Tracez Processor Jul 9, 2020
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify the concurrency consideration.

@jajanet

This comment has been minimized.

@jajanet jajanet requested a review from reyang July 14, 2020 14:43
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming comments will be resolved.

@reyang
Copy link
Member

reyang commented Jul 15, 2020

@jajanet would you rebase please? Thanks.

@jajanet jajanet requested a review from reyang July 15, 2020 16:35
@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 15, 2020
@reyang reyang merged commit 4291d22 into open-telemetry:master Jul 16, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…s-create-or-update-comment-digest

Update peter-evans/create-or-update-comment digest to 1a53cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants