Add OStream metrics exporter #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
@reyang @pyohannes This PR should be ready for review and can be merged once the Sketch Aggregator is merged. |
…mphries/opentelemetry-cpp into stream-metrics-exporter
reyang
reviewed
Aug 4, 2020
reyang
reviewed
Aug 4, 2020
| auto agg = nostd::get<std::shared_ptr<sdkmetrics::Aggregator<T>>>(value); | ||
| auto aggKind = agg->get_aggregator_kind(); | ||
|
|
||
| if (agg != nullptr) |
Member
There was a problem hiding this comment.
Could we simply the flow here:
- short circuit if
agg == nullptr. - use
switch casefor the conditions.
So the flow would look like:
if (!agg) return;
switch (aggKind) {
case x:
// do something
break;
}
reyang
added
the
pr:please-merge
Member
Author
|
Addressed comments and rebased @reyang Let me know if I didn't address your comments correctly. |
Member
Author
|
Design document can be found here |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
chore(deps): update dependency ubuntu to v24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the OStream Exporter for the metrics data pipeline. This MetricsExporter takes data in from the Controller in the form of Records. The exporter then takes the records and gets all of the relevant data out of it and sends it to an ostream. The default configuration is to send the recordable data to stdout. Unlike SpanExporters, metrics exporters are currently not required to implement a Shutdown() function.
This PR contains a lot of code from PRs currently open. These should either be removed from this PR before merging or should be merged before this one is. Please only review the exporter portion of this PR and redirect all feedback on Aggregators to their specific PRs.
CI Tests were not running on the old PR, so I made a new one.