Skip to content

[CONFIGURATION] Update registry factory to return a unique_ptr - #4487

Merged
dbarker merged 3 commits into
open-telemetry:mainfrom
dbarker:config_registry_factory_returns_unique_ptr
Aug 27, 2026
Merged

[CONFIGURATION] Update registry factory to return a unique_ptr#4487
dbarker merged 3 commits into
open-telemetry:mainfrom
dbarker:config_registry_factory_returns_unique_ptr

Conversation

@dbarker

@dbarker dbarker commented Aug 26, 2026

Copy link
Copy Markdown
Member

Followup from #4367 (comment)

Changes

  • Configuration RegistryFactory::Create returns a unique_ptr

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker
dbarker marked this pull request as ready for review August 26, 2026 19:46
@dbarker
dbarker requested a review from a team as a code owner August 26, 2026 19:46
@dbarker dbarker changed the title [CONFIGURATION] update registry factory to return a unique_ptr [CONFIGURATION] Update registry factory to return a unique_ptr Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.12%. Comparing base (06423fb) to head (c45b436).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4487      +/-   ##
==========================================
- Coverage   83.13%   83.12%   -0.00%     
==========================================
  Files         519      519              
  Lines       20256    20256              
==========================================
- Hits        16837    16835       -2     
- Misses       3419     3421       +2     
Files with missing lines Coverage Δ
sdk/src/configuration/registry_factory.cc 85.72% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarker
dbarker merged commit 75e36ac into open-telemetry:main Aug 27, 2026
130 of 131 checks passed
@dbarker
dbarker deleted the config_registry_factory_returns_unique_ptr branch August 27, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants