Restore java 25 lts to test matrix, collect coverage on java 25 - #8678
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-07-31 19:24 UTC Status above doesn't look right?
|
trask
approved these changes
Jul 31, 2026
jack-berg
commented
Jul 31, 2026
| DoubleSumTester::new, | ||
| /* dataAllocRateReductionPercentage= */ 97.3f, | ||
| /* allowedPercentOffset= */ 2.0f), | ||
| /* allowedPercentOffset= */ 4.0f), |
Member
Author
There was a problem hiding this comment.
Since we're running jmh-based-test only on the latest LTS, when LTS changed from 21->25 it also changed the memory allocation profile such that we need to tune the assertion parameters in InstrumentGarbageCollectionBenchmarkTest. This here says double_sum memory allocation must reduce by 97+-4%, when going from immutable_data to reuseable_data mode. Previously it was 97+-2%.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8678 +/- ##
============================================
+ Coverage 91.47% 91.48% +0.01%
- Complexity 10465 10467 +2
============================================
Files 1021 1021
Lines 27694 27694
Branches 3247 3247
============================================
+ Hits 25333 25337 +4
+ Misses 1617 1615 -2
+ Partials 744 742 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.