opentelemetry-test-utils: skip weaver tests on PyPy#5301
Closed
mwimpelberg28 wants to merge 1 commit into
Closed
Conversation
|
|
mwimpelberg28
force-pushed
the
fix/weaver-tests-pypy-5176
branch
from
313c86d to
f3a69d3
Compare
) The weaver binary's gRPC C core crashes with SIGABRT (exit code -6) on PyPy due to an epoll_wait EBADF error in ev_epoll1_linux.cc. This is a known incompatibility between gRPC's epoll1 event engine and PyPy subprocesses that cannot be fixed from the Python side. Skip both weaver test classes on PyPy, consistent with how other gRPC-dependent tests are excluded from PyPy in this repo. Assisted-by: Claude Sonnet 4.6
mwimpelberg28
force-pushed
the
fix/weaver-tests-pypy-5176
branch
from
f3a69d3 to
06b0414
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5176.
epoll_wait EBADFerror inev_epoll1_linux.cc. This is a known incompatibility between gRPC's epoll1 event engine and PyPy subprocesses that cannot be fixed from the Python side.@unittest.skipIf(platform.python_implementation() == "PyPy", ...), consistent with how other gRPC-dependent tests are already excluded from PyPy in this repo (e.g.,opencensus-shim).Test plan
pypy3-test-opentelemetry-test-utilsnow shows the weaver tests as skipped rather than failing/erroringpy312-test-opentelemetry-test-utils(CPython) continues to run the weaver tests as before🤖 Generated with Claude Code