Count post-shutdown-dropped records as already_shutdown on processor.processed - #5509
Open
cijothomas wants to merge 3 commits into
Open
Conversation
…ady_shutdown
Batch (span+log) and simple log processors previously dropped records
silently after shutdown. Count them on otel.sdk.processor.{span,log}.processed
with error.type=already_shutdown, matching the semantic conventions and the
.NET SDK. SimpleSpanProcessor is unchanged (it has no shutdown gate).
Assisted-by: Claude Opus 4.8
Assisted-by: Claude Opus 4.8
Assisted-by: Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5472. The batch (span + log) and simple log processors dropped records silently once shut down. This counts those drops on
otel.sdk.processor.{span,log}.processedwitherror.type=already_shutdown, which the semantic conventions define as a valid value for this metric.Question for reviewers:
SimpleSpanProcessoris intentionally left unchanged here — it has no shutdown gate, so it keeps exporting spans aftershutdown()rather than dropping them, and there's nothing to count asalready_shutdown. Adding a shutdown gate there would be a behavior change (post-shutdown spans would stop being exported). If there's appetite to align it, I'll do that as a separate PR — let me know.