Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Sep 5, 2024

Error - https://github.com/open-telemetry/opentelemetry-rust/actions/runs/10714378235/job/29707978476?pr=2073

error: package `tokio-util v0.7.12` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p tokio-util@0.7.12 --precise ver
where `ver` is the latest version of `tokio-util` supporting rustc 1.65.0
Error: Process completed with exit code 101.

The error is coming from opentelemetry-http which has msrv of 1.65.0. The tokio-util is optional dependency there (through tokio), so as of now, sticking to the last supported version of tokio-util should be fine.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (4a86e16) to head (27fee3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2081     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files        121     121             
  Lines      21143   21143             
=======================================
- Hits       16479   16478      -1     
- Misses      4664    4665      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb marked this pull request as ready for review September 5, 2024 19:44
@lalitb lalitb requested a review from a team September 5, 2024 19:44
@jayvdb jayvdb mentioned this pull request Sep 7, 2024
4 tasks
@cijothomas cijothomas merged commit a50e3ff into open-telemetry:main Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants