Clarify the non-blocking check failure note - #189
Merged
trask merged 2 commits intoJul 30, 2026
Conversation
Pull request dashboard statusMerged · refreshed 2026-07-30 12:40 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies non-blocking check failure messaging across dashboard routes.
Changes:
- Adds “also” when non-blocking failures accompany required failures.
- Shows only check names on non-author routes.
- Updates related tests, though some assertions remain too permissive.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/scripts/pull-request-dashboard/pr_status_comment.py |
Adds context-specific failure summaries. |
.github/scripts/pull-request-dashboard/test_pr_status_comment.py |
Updates expected status messages. |
Comments suppressed due to low confidence (1)
.github/scripts/pull-request-dashboard/test_pr_status_comment.py:346
- These expected values are still prefixes of the old verbose lines, and the later
assertIntherefore passes without the production change. Add line boundaries so both parameterized cases actually verify that the redundant suffix was removed.
"**Non-blocking check failure:** CodeQL",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mx-psi
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note reading
Investigate required status check failures. Note: codecov/patch is failing but is not a required check.scanned as a contradiction, since nothing tied the second sentence back to the first. It now says "is also failing", which makes it read as an aside about an additional failure.On non-author routes the same text was rendered standalone under a
**Non-blocking check failure:**label, where "also" would dangle and the rest of the sentence just restated the label, so that case now lists the check names only.