Skip to content

Use a single flag to handle all changes for large repo#34

Merged
maryliag merged 2 commits into
open-telemetry:mainfrom
maryliag:large-repo
Jul 3, 2026
Merged

Use a single flag to handle all changes for large repo#34
maryliag merged 2 commits into
open-telemetry:mainfrom
maryliag:large-repo

Conversation

@maryliag

@maryliag maryliag commented Jul 2, 2026

Copy link
Copy Markdown
Member

Use a single large_repo variable to cap the section at 50 PRs, don't show draft PRs and don't get trigger by webhook calls (only hourly and manual).

The amount of calls was making the GH API hit the quota

Copilot AI review requested due to automatic review settings July 2, 2026 21:42
@maryliag maryliag requested review from a team and trask as code owners July 2, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the pull-request-dashboard configuration by collapsing the two separate large-repo tuning knobs (max_rows_per_section and skip_drafts) into a single large_repo boolean. It also introduces a new behavior where webhook-driven runs are skipped for large_repo targets to avoid exhausting the GitHub App's hourly API quota, while scheduled and manual runs still process them.

Changes:

  • Replaced max_rows_per_section/skip_drafts with a single large_repo flag across the Python script, reusable workflow, config, and docs (50-row cap + drafts omitted are now presets behind the flag).
  • Added a Check webhook large-repo skip step that suppresses webhook-triggered refreshes (token minting + dashboard job) for large repos, driven by the trigger event type.
  • Updated repositories.json and README.md to reflect the consolidated flag and the new triggering behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/scripts/pull-request-dashboard/dashboard.py Replaces two CLI args with --large-repo, introduces LARGE_REPO_MAX_ROWS_PER_SECTION = 50, and removes now-obsolete validation.
.github/workflows/pull-request-dashboard-repo.yml Swaps the two reusable-workflow inputs for large_repo and passes --large-repo to the script.
.github/workflows/pull-request-dashboard.yml Adds webhook large-repo skip step and gates token creation / precondition on it; passes large_repo to the matrix job.
.github/scripts/pull-request-dashboard/repositories.json Updates the collector-contrib entry to use large_repo: true.
pull-request-dashboard/README.md Documents the consolidated large_repo field and its rendering + triggering effects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mx-psi mx-psi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we could call the option "is_collector_contrib" 😅. LGTM!

@maryliag maryliag merged commit f21123e into open-telemetry:main Jul 3, 2026
5 checks passed
@maryliag maryliag deleted the large-repo branch July 3, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants