Fix PR dashboard workflow configuration#8
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes configuration issues in the recently added reusable PR dashboard workflows. The caller (pull-request-dashboard.yml) now grants the GITHUB_TOKEN permissions required by the nested reusable-workflow jobs and passes the dashboard secrets explicitly, the reusable repo workflow declares those secrets as required inputs, and the Netlify deploy workflow recreates its dispatcher environment variables before re-scoping them to production/functions.
Changes:
- Add a job-level
permissions:block torun-repo-dashboardmatching the union of the called jobs' needs, and passPR_DASHBOARD_PRIVATE_KEY,COPILOT_GITHUB_TOKEN, andSLACK_WEBHOOK_URLexplicitly viasecrets:. - Declare those three secrets (all
required: true) underon.workflow_call.secretsin the reusable repo workflow. - Unset the two managed Netlify dispatcher env vars (with
|| true) before re-setting them toproduction/functionsscope.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pull-request-dashboard.yml | Adds explicit permissions and secrets to the run-repo-dashboard reusable-workflow call; removes the environment-resolution comment. |
| .github/workflows/pull-request-dashboard-repo.yml | Declares PR_DASHBOARD_PRIVATE_KEY, COPILOT_GITHUB_TOKEN, and SLACK_WEBHOOK_URL as required workflow_call secrets. |
| .github/workflows/deploy-pull-request-dashboard-webhook.yml | Unsets the managed dispatcher env vars before re-creating them with production/functions scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trask
force-pushed
the
fixes
branch
2 times, most recently
from
db86038 to
9cbd255
Compare
maryliag
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare and pass the PR dashboard reusable workflow secrets explicitly. The called workflow now defines the three required secrets in
workflow_call.secrets, and the caller forwards only those values instead of relying on direct secret lookup from the called jobs' protected environment.The called jobs keep
environment: protectedfor protected environment variables such asPR_DASHBOARD_APP_ID, but secret values are now part of the reusable workflow call contract.