Skip to content

add GCS related environment variables#363

Merged
tjbck merged 2 commits into
open-webui:mainfrom
kahghi:add-gcs-storage-provider-docs
Jan 29, 2025
Merged

add GCS related environment variables#363
tjbck merged 2 commits into
open-webui:mainfrom
kahghi:add-gcs-storage-provider-docs

Conversation

@kahghi

@kahghi kahghi commented Jan 21, 2025

Copy link
Copy Markdown

Introduces two environment variables required to utilise GCS buckets.
Related to PR

- Description: Sets the secret access key for S3 storage.

### Google Cloud Storage
#### `GCS_BUCKET_NAME`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### `GCS_BUCKET_NAME`
#### `GCS_BUCKET_NAME`

- Type: `str`
- Description: Sets the bucket name for Google Cloud Storage

#### `GOOGLE_APPLICATION_CREDENTIALS_JSON`

This comment was marked as resolved.


#### `GOOGLE_APPLICATION_CREDENTIALS_JSON`

- Type: `JSON`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a string? I don't think it can receive a JSON type. It will be confusing for people I think. Maybe in the description you can add a quick hint on how it can be generated. I would also add that is optional if running using GCP.

BTW in the tests of the other PR did you test both sending and not sending this variable?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, both are tested

@kahghi kahghi changed the title [WIP] add GCS related environment variables add GCS related environment variables Jan 22, 2025

@rragundez rragundez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tjbck Simple update to the docs with the GCS Storage provider that was merged in dev recently

@kahghi

kahghi commented Jan 27, 2025

Copy link
Copy Markdown
Author

LGTM. @tjbck Simple update to the docs with the GCS Storage provider that was merged in dev recently

@tjbck this PR is good to go, please have a review and merge if it looks good :)

@tjbck

tjbck commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Thanks everyone!

@tjbck
tjbck merged commit 1ad0ee9 into open-webui:main Jan 29, 2025
danielrosehill pushed a commit to danielrosehill/openwebui-docs that referenced this pull request Mar 2, 2025
…r-docs

add GCS related environment variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants