[Fix #1496] Closing managed channel#1497
Merged
Merged
Conversation
fjtirado
requested review from
Copilot and
mcruzdev
and removed request for
Copilot
June 29, 2026 12:45
fjtirado
commented
Jun 29, 2026
|
|
||
| public class GrpcExecutor implements CallableTask { | ||
|
|
||
| public static final String GRPC_CHANNEL_PROVIDER = "grpcChannelProvider"; |
Collaborator
Author
There was a problem hiding this comment.
This is public on purpose so upstream can resuse without copy pasting the string value
mcruzdev
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #1496 by ensuring gRPC ManagedChannel instances created for task execution are explicitly shut down rather than left for eventual GC, reducing noisy shutdown/GC-related logs.
Changes:
- Inlines gRPC channel resolution/creation into
GrpcExecutor(removingGrpcChannelResolver). - Adds a
finallyshutdown path to closeManagedChannelinstances after scheduling the gRPC call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java | Creates or injects a gRPC channel and attempts to shut down managed channels to avoid leak/log pollution. |
| impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcChannelResolver.java | Removes the previous channel resolver helper (logic moved into GrpcExecutor). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fjtirado <ftirados@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1496