Execute grpcCalls on Application executor service by fjtirado · Pull Request #1506 · open-workflow-specification/sdk-java

fjtirado · 2026-06-29T15:48:49Z

Convert grpc calls in real async calls over the executor service provided by the application

Copilot

Pull request overview

This PR updates the gRPC executor implementation so gRPC calls (including streaming) run on the application-provided executor service, aligning async execution and callback handling with the workflow runtime’s configured thread pool.

Changes:

Route gRPC ClientCall execution/callbacks through WorkflowApplication.executorService() via CallOptions.withExecutor(...).
Offload client/bidi streaming request message production to the application executor instead of running inline on the caller thread.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/ProtobufMessageUtils.java	Moves streaming request writes onto the application executor; needs stricter error/rejection handling to avoid hanging futures and invalid stream termination.
impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java	Configures gRPC calls to use the application executor via `CallOptions.withExecutor(...)` and updates streaming call sites accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Signed-off-by: fjtirado <ftirados@ibm.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings June 29, 2026 15:48

fjtirado force-pushed the grpc_executor_thread branch from 8d1c9f6 to 457a432 Compare June 29, 2026 15:49

Copilot started reviewing on behalf of fjtirado June 29, 2026 15:49 View session

fjtirado force-pushed the grpc_executor_thread branch from 457a432 to 3b59875 Compare June 29, 2026 15:51

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/ProtobufMessageUtils.java Outdated

Copilot AI review requested due to automatic review settings June 29, 2026 15:51

Copilot started reviewing on behalf of fjtirado June 29, 2026 15:51 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/ProtobufMessageUtils.java Outdated

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/ProtobufMessageUtils.java Outdated

fjtirado force-pushed the grpc_executor_thread branch from 3b59875 to 1a034a8 Compare June 29, 2026 16:13

Copilot AI review requested due to automatic review settings June 29, 2026 16:19

fjtirado force-pushed the grpc_executor_thread branch from 1a034a8 to 37f5f45 Compare June 29, 2026 16:19

Copilot started reviewing on behalf of fjtirado June 29, 2026 16:20 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

fjtirado force-pushed the grpc_executor_thread branch from 37f5f45 to f514e15 Compare June 29, 2026 16:41

Copilot AI review requested due to automatic review settings June 29, 2026 17:01

fjtirado force-pushed the grpc_executor_thread branch from f514e15 to 743365c Compare June 29, 2026 17:01

Copilot started reviewing on behalf of fjtirado June 29, 2026 17:01 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/FileDescriptorReader.java Outdated

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/FileDescriptorReader.java Outdated

fjtirado force-pushed the grpc_executor_thread branch from 743365c to f37ea5c Compare June 29, 2026 17:10

Copilot AI review requested due to automatic review settings June 29, 2026 17:16

fjtirado force-pushed the grpc_executor_thread branch from f37ea5c to c6f7801 Compare June 29, 2026 17:16

Copilot started reviewing on behalf of fjtirado June 29, 2026 17:16 View session

fjtirado force-pushed the grpc_executor_thread branch from c6f7801 to 9ce831b Compare June 29, 2026 17:17

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 29, 2026 17:20

Copilot started reviewing on behalf of fjtirado June 29, 2026 17:20 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java Outdated

mcruzdev approved these changes Jun 29, 2026

View reviewed changes

fjtirado force-pushed the grpc_executor_thread branch from 9ce831b to 54def0c Compare June 30, 2026 06:17

Copilot AI review requested due to automatic review settings June 30, 2026 06:52

fjtirado force-pushed the grpc_executor_thread branch from 54def0c to 6607242 Compare June 30, 2026 06:52

Copilot started reviewing on behalf of fjtirado June 30, 2026 06:52 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

fjtirado force-pushed the grpc_executor_thread branch from 6607242 to 8502633 Compare June 30, 2026 07:14

Copilot AI review requested due to automatic review settings June 30, 2026 07:19

fjtirado force-pushed the grpc_executor_thread branch 2 times, most recently from 16d66cb to 638e5ac Compare June 30, 2026 07:19

Copilot started reviewing on behalf of fjtirado June 30, 2026 07:19 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

fjtirado force-pushed the grpc_executor_thread branch from 638e5ac to 715a3b1 Compare June 30, 2026 07:23

Copilot AI review requested due to automatic review settings June 30, 2026 07:49

fjtirado force-pushed the grpc_executor_thread branch from 715a3b1 to 9a65dac Compare June 30, 2026 07:49

Copilot started reviewing on behalf of fjtirado June 30, 2026 07:50 View session

fjtirado force-pushed the grpc_executor_thread branch from 9a65dac to c5667f8 Compare June 30, 2026 07:50

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/ProtobufMessageUtils.java Outdated

Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowError.java

Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowError.java

fjtirado force-pushed the grpc_executor_thread branch from c5667f8 to d41cbec Compare June 30, 2026 07:53

Copilot AI review requested due to automatic review settings June 30, 2026 07:56

fjtirado force-pushed the grpc_executor_thread branch from d41cbec to 95dcc10 Compare June 30, 2026 07:56

Copilot started reviewing on behalf of fjtirado June 30, 2026 07:57 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

fjtirado force-pushed the grpc_executor_thread branch from 95dcc10 to 5d6d5ac Compare June 30, 2026 08:09

Execute grpcCalls on Application executor service

727cb2e

Signed-off-by: fjtirado <ftirados@ibm.com>

Copilot AI review requested due to automatic review settings June 30, 2026 08:13

fjtirado force-pushed the grpc_executor_thread branch from 5d6d5ac to 727cb2e Compare June 30, 2026 08:13

Copilot started reviewing on behalf of fjtirado June 30, 2026 08:14 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread impl/grpc/src/main/java/io/serverlessworkflow/impl/executors/grpc/GrpcExecutor.java

fjtirado merged commit b0d9e6a into open-workflow-specification:main Jun 30, 2026
3 checks passed

Uh oh!

Conversation

fjtirado commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees