Make cross_score work via CLI and small style fixes#474
Merged
agalitsyna merged 1 commit intoFeb 12, 2024
Merged
Conversation
sergpolly
approved these changes
Jan 31, 2024
Member
sergpolly
left a comment
sergpolly
left a comment
There was a problem hiding this comment.
this seems like an innocent PR into sandbox for a feature that already exist - so approve
Member
|
Thanks, @alexyakyshev , I'll work it into main branch of cooltools sandbox. Highly appreciated that you looked into that! |
agalitsyna
added a commit
that referenced
this pull request
Feb 13, 2024
* Make cross_score work via CLI and small style fixes (#474) * Cross-score fix of edge case fit bin-wise annotation of cross-scores * Black and parameter naming issue --------- Co-authored-by: Aleksandr <r1kanat@yandex.ru>
Member
|
thank you, @alexyakyshev and @sergpolly for checking the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross score cannot work in CLI due to the lack of idiom 'if name == "main":'