Skip to content

Conversation

@hrahmanin
Copy link
Collaborator

No description provided.

@hrahmanin hrahmanin requested a review from gfudenberg January 16, 2025 03:43
@golobor
Copy link
Member

golobor commented Jan 16, 2025

could you please exclude .ipynb_checkpoints from the commit?
(typically, this is prevented via .gitignore)

@golobor
Copy link
Member

golobor commented Jan 16, 2025

another minor suggestion - i think there may be a much more efficient implementation of the search via np.searchsorted(l_sites, r_sites)

@hrahmanin
Copy link
Collaborator Author

@golobor Thanks for your comment regarding the np.searchsorted function. I now understand that it finds the positions where elements should be inserted to maintain order between two lists. However, in my case, I'm looking for elements with an exact difference of 1 between the arrays.

@golobor
Copy link
Member

golobor commented Feb 10, 2025

Hi Hadi,
You're right, but my point is that you could speed up your algorithm if you were to use searchsorted to find consecutive legs of smcs and then checking for distance==1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants