Prevent duplicate close of client connection #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a running execution is stopped by the client (through the WebSocket connection), we immediately call `close_client_connection` to terminate Tubesock connection to the browser and stop the runner. However, since the regular workflow also included a call to `close_client_connection`, it might have been called twice.
Dome-GER
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a running execution is stopped by the client (through the WebSocket connection), we immediately call
close_client_connectionto terminate Tubesock connection to the browser and stop the runner. However, since the regular workflow also included a call toclose_client_connection, it might have been called twice.