Skip to content

Conversation

@RajaVamsi11
Copy link
Contributor

@RajaVamsi11 RajaVamsi11 commented Mar 1, 2020

Fixes #1364

Please Add Screenshots If there are any UI changes.

Before:

Screenshot_2020-03-01-21-00-43-310_com mifos mifosxdroid 1

After:
Screenshot_2020-03-02-10-35-42-648_com mifos mifosxdroid

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@RajaVamsi11
Copy link
Contributor Author

@tarun0 @Rachittt Can you please review it?

@RajaVamsi11 RajaVamsi11 force-pushed the IncorrectSnackbarMessages branch from a885628 to 3f9ea5e Compare March 2, 2020 05:01
@RajaVamsi11
Copy link
Contributor Author

@Rachittt Done.

Copy link
Member

@rchtgpt rchtgpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it is an error message, the variable name should have "error" in it. This makes it easier for future developers and contributors.

@RajaVamsi11 RajaVamsi11 force-pushed the IncorrectSnackbarMessages branch from 3f9ea5e to 648da75 Compare March 2, 2020 09:10
@rchtgpt rchtgpt merged commit d7f8b48 into openMF:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Snack bar message in Login Activity

3 participants