Update: Kotlin conversion

mifosng-android/build.gradle

@@ -110,6 +110,8 @@ android {
     lintOptions {
         abortOnError false
         disable 'InvalidPackage'
+        disable 'MissingTranslation'
+        disable 'OutdatedLibrary'
     }
 
 
@@ -196,7 +198,7 @@ dependencies {
     kapt 'androidx.lifecycle:lifecycle-compiler:2.0.0'
 
     //Square dependencies
-    implementation('com.squareup.retrofit2:retrofit:$rootProject.retrofitVersionLatest') {
+    implementation("com.squareup.retrofit2:retrofit:$rootProject.retrofitVersionLatest") {
         // exclude Retrofit’s OkHttp peer-dependency module and define your own module import
         exclude module: 'okhttp'
     }
@@ -216,7 +218,7 @@ dependencies {
     implementation 'com.facebook.stetho:stetho-okhttp3:1.3.1'
 
 
-    implementation 'com.joanzapata.iconify:android-iconify-material:2.1.1' // (v2.0.0)
+    implementation "com.joanzapata.iconify:android-iconify-material:2.1.1" // (v2.0.0)
     implementation('com.crashlytics.sdk.android:crashlytics:2.6.6@aar') {
         transitive = true
     }

mifosng-android/src/main/java/com/mifos/mifosxdroid/ClientListActivity.kt

@@ -0,0 +1,18 @@
+/*
+ * This project is licensed under the open source MPL V2.
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
+package com.mifos.mifosxdroid
+
+import android.os.Bundle
+import com.mifos.mifosxdroid.core.MifosBaseActivity
+import com.mifos.mifosxdroid.online.clientlist.ClientListFragment
+
+class ClientListActivity : MifosBaseActivity() {
+    public override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        setContentView(R.layout.activity_toolbar_container)
+        showBackButton()
+        replaceFragment(ClientListFragment(), false, R.id.container)
+    }
+}

mifosng-android/src/main/java/com/mifos/mifosxdroid/SettingsActivity.kt

@@ -0,0 +1,19 @@
+package com.mifos.mifosxdroid
+
+import com.mifos.mifosxdroid.core.MifosBaseActivity
+import android.os.Bundle
+import com.mifos.mifosxdroid.SettingsFragment
+
+/**
+ * Created by mayankjindal on 22/07/17.
+ */
+class SettingsActivity : MifosBaseActivity() {
+    public override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        setContentView(R.layout.activity_toolbar_container)
+        showBackButton()
+        fragmentManager.beginTransaction()
+                .replace(R.id.container, SettingsFragment())
+                .commit()
+    }
+}

mifosng-android/src/main/java/com/mifos/mifosxdroid/SettingsFragment.kt

@@ -0,0 +1,42 @@
+package com.mifos.mifosxdroid
+
+import android.os.Bundle
+import android.preference.Preference.OnPreferenceChangeListener
+import android.preference.PreferenceFragment
+import android.preference.SwitchPreference
+import com.mifos.mifosxdroid.dialogfragments.syncsurveysdialog.SyncSurveysDialogFragment
+import com.mifos.utils.FragmentConstants
+
+/**
+ * Created by mayankjindal on 22/07/17.
+ */
+class SettingsFragment : PreferenceFragment() {
+    var mEnableSyncSurvey: SwitchPreference? = null
+    override fun onCreate(savedInstanceState: Bundle?) {
+
+        super.onCreate(savedInstanceState)
+        addPreferencesFromResource(R.xml.preferences)
+        mEnableSyncSurvey = findPreference(resources.getString(R.string.sync_survey)) as SwitchPreference
+        mEnableSyncSurvey!!.onPreferenceChangeListener =
+                OnPreferenceChangeListener { preference, newValue ->
+            if (newValue as Boolean) {
+                val syncSurveysDialogFragment = SyncSurveysDialogFragment.newInstance()
+                val fragmentTransaction = fragmentManager.beginTransaction()
+                fragmentTransaction.addToBackStack(FragmentConstants.FRAG_SURVEYS_SYNC)
+                syncSurveysDialogFragment.isCancelable = false
+                syncSurveysDialogFragment.show(fragmentTransaction,
+                        resources.getString(R.string.sync_clients))
+            }
+            true
+        }
+    }
+
+    companion object {
+        fun newInstance(): SettingsFragment {
+            val fragment = SettingsFragment()
+            val args = Bundle()
+            fragment.arguments = args
+            return fragment
+        }
+    }
+}

mifosng-android/src/main/java/com/mifos/mifosxdroid/activity/pathtracking/PathTrackingService.java

@@ -5,17 +5,22 @@
 
 package com.mifos.mifosxdroid.activity.pathtracking;
 
+import android.Manifest;
 import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.app.Service;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
+import android.content.pm.PackageManager;
 import android.location.Location;
 import android.os.Bundle;
 import android.os.IBinder;
+
+import androidx.core.app.ActivityCompat;
 import androidx.core.app.NotificationCompat;
+
 import android.util.Log;
 import android.widget.Toast;
 
@@ -102,6 +107,33 @@ protected void createLocationRequest() {
     }
 
     protected void startLocationUpdates() {
+        if (ActivityCompat.checkSelfPermission(this, Manifest.permission
+                .ACCESS_FINE_LOCATION) != PackageManager
+                .PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest
+                .permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+            // TODO: Consider calling
+            //    ActivityCompat#requestPermissions
+            // here to request the missing permissions, and then overriding
+            //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
+            //                                          int[] grantResults)
+            // to handle the case where the user grants the permission. See the documentation
+            // for ActivityCompat#requestPermissions for more details.
+            return;
+        }
+        if (ActivityCompat.checkSelfPermission(this, Manifest.permission
+                .ACCESS_FINE_LOCATION) != PackageManager
+                .PERMISSION_GRANTED && ActivityCompat
+                .checkSelfPermission(this, Manifest.permission
+                        .ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+            // TODO: Consider calling
+            //    ActivityCompat#requestPermissions
+            // here to request the missing permissions, and then overriding
+            //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
+            //                                          int[] grantResults)
+            // to handle the case where the user grants the permission. See the documentation
+            // for ActivityCompat#requestPermissions for more details.
+            return;
+        }
         LocationServices.FusedLocationApi.requestLocationUpdates(
                 googleApiClient, locationRequest, this);
     }
@@ -124,6 +156,34 @@ public int onStartCommand(Intent intent, int flags, int startId) {
     @Override
     public void onConnected(Bundle bundle) {
         if (currentLocation == null) {
+            if (ActivityCompat.checkSelfPermission(this, Manifest
+                    .permission.ACCESS_FINE_LOCATION) != PackageManager
+                    .PERMISSION_GRANTED && ActivityCompat
+                    .checkSelfPermission(this, Manifest.permission
+                            .ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+                // TODO: Consider calling
+                //    ActivityCompat#requestPermissions
+                // here to request the missing permissions, and then overriding
+                //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
+                //                                          int[] grantResults)
+                // to handle the case where the user grants the permission. See the documentation
+                // for ActivityCompat#requestPermissions for more details.
+                return;
+            }
+            if (ActivityCompat.checkSelfPermission(this, Manifest
+                    .permission.ACCESS_FINE_LOCATION) != PackageManager
+                    .PERMISSION_GRANTED && ActivityCompat
+                    .checkSelfPermission(this, Manifest.permission
+                            .ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+                // TODO: Consider calling
+                //    ActivityCompat#requestPermissions
+                // here to request the missing permissions, and then overriding
+                //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
+                //                                          int[] grantResults)
+                // to handle the case where the user grants the permission. See the documentation
+                // for ActivityCompat#requestPermissions for more details.
+                return;
+            }
             currentLocation = LocationServices.FusedLocationApi.getLastLocation(googleApiClient);
             latLngs.add(new UserLatLng(currentLocation.getLatitude(),
                     currentLocation.getLongitude()));

mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/collectionsheetdialog/CollectionSheetDialogFragment.java

@@ -56,7 +56,6 @@ public static CollectionSheetDialogFragment newInstance(String date, int members
 
     @Override
     public void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
         ((MifosBaseActivity) getActivity()).getActivityComponent().inject(this);
         date = getArguments().getString(Constants.REPAYMENT_DATE);
         members = getArguments().getInt(Constants.MEMBERS);