Add Support Secrets Gradle plugin #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
May 8, 2024
therajanmaurya
changed the title
- Removed optional secrets.properties file declaration - Configured And Applied Keys into default file
therajanmaurya
requested changes
May 8, 2024
therajanmaurya
requested changes
May 9, 2024
secrets.defaults.properties
Outdated
| # Provide GEO API Key | ||
| GEO_API_KEY = AIzaSyAZTZqvDGyyw21z2Ee7N-dE_WuZQwKL0bs | ||
|
|
||
| DEMO_SERVER_CONFIG = "https://,demo.mifos.community,/fineract-provider/api/v1/,80,default" |
There was a problem hiding this comment.
This is right way, we are going to keep this only, remove rest of it
There was a problem hiding this comment.
can you also add a comment to DEMO_SERVER_CONFIG
#Update DEMO_SERVER_CONFIG according below mentioned your server config
#PROTOCOL_HTTPS = https://
#API_ENDPOINT = demo.mifos.community
#API_PATH = /fineract-provider/api/v1/
#PORT = 80
#TENANT = default
core/network/build.gradle.kts
Outdated
| id(libs.plugins.kotlin.kapt.get().pluginId) | ||
| } | ||
|
|
||
| val protocol = project.properties["PROTOCOL_HTTPS"].toString() |
There was a problem hiding this comment.
remove these Build config fields
therajanmaurya
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2092
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.