Skip to content

Conversation

@biplab1
Copy link
Contributor

@biplab1 biplab1 commented Jun 26, 2025

Fixes - Jira-#461

Summary of changes:

  1. Prevented the temporary "There is no identifier to show" screen from appearing before the actual identifier list is loaded.
  2. Fixed a UI issue where the create identifier dialog briefly stretched vertically before rendering correctly.

Before the fix:

Before-bug-fixes.webm

After the fix:

After-bug-fixes.webm

Client Identifiers All Features:
User flow:

  1. Client Details → ⋮ → Identifiers → On Identifier ⋮ → Delete Identifier → Identifiers Screen
  2. Identifiers Screen → ⋮ “+” icon → Create Identifier → Identifier Screen
client-identifiers-all-features.webm
  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@biplab1 biplab1 changed the base branch from development to kmp-impl June 26, 2025 17:20
@revanthkumarJ
Copy link
Contributor

@biplab1 can you also update in video what happens when we create an identifier and also other functionalities of this sub feature

@biplab1
Copy link
Contributor Author

biplab1 commented Jun 26, 2025

@biplab1 can you also update in video what happens when we create an identifier and also other functionalities of this sub feature

I’ve added a video covering all features in the PR description.

I had already updated all the features of the Client Identifier sub-feature in the Jira ticket yesterday (MIFOSAC-461). However, I'm also updating the status here, now including the recent bug fixes.

The Client Identifier Dialog is a separate sub-feature used for creating a client identifier. I will be picking that up next.

@niyajali niyajali merged commit 47e9f10 into openMF:kmp-impl Jun 27, 2025
1 check passed
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
…dentifiers (openMF#2415)

Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
…dentifiers (openMF#2415)

Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants