fix: Update server config not working #2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
approved these changes
Jul 14, 2025
Contributor
revanthkumarJ
left a comment
revanthkumarJ
left a comment
There was a problem hiding this comment.
Looks good to me ,
biplab1
approved these changes
Jul 14, 2025
Contributor
biplab1
left a comment
biplab1
left a comment
There was a problem hiding this comment.
The changes are fine from my side, good to go.
...src/commonMain/kotlin/com/mifos/feature/settings/updateServer/UpdateServerConfigViewModel.kt
Show resolved
Hide resolved
core/network/src/commonMain/kotlin/com/mifos/core/network/di/NetworkModule.kt
Show resolved
Hide resolved
niyajali
requested changes
Jul 16, 2025
core/datastore/src/commonMain/kotlin/com/mifos/core/datastore/UserPreferencesDataSource.kt
Show resolved
Hide resolved
Collaborator
|
@itsPronay please upload a video to demonstrate the changes |
Collaborator
Author
|
@niyajali I have uploaded the video, please check |
niyajali
approved these changes
Jul 28, 2025
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-494
Screenrecorder-2025-07-24-21-13-57-372.mp4