MIFOSAC-572 Fixed deposit account #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKalpeshPawar
changed the title
itsPronay
reviewed
Sep 2, 2025
...ommonMain/kotlin/com/mifos/feature/client/clientIdentitiesList/ClientIdentitiesListScreen.kt
Show resolved
Hide resolved
itsPronay
reviewed
Sep 2, 2025
...c/commonMain/kotlin/com/mifos/feature/client/fixedDepositAccount/FixedDepositAccountRoute.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Sep 2, 2025
...mmonMain/kotlin/com/mifos/feature/client/fixedDepositAccount/FixedDepositAccountViewModel.kt
Outdated
Show resolved
Hide resolved
itsPronay
approved these changes
Sep 2, 2025
revanthkumarJ
approved these changes
Sep 3, 2025
# Conflicts: # core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosActionsListingCardComponent.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI/UX - Jira-#MIFOSAC-572
Main goal: Client Fixed deposit accounts screen.
Also added breadcrumb navigation for recurring deposit account screen and the current screen.
Other changes:
I have changed the Actions class inside the MifosActionsListingCardComponent file.
Currently all screens are using the same icons in the listing cards, but Figma designs have different icons in different screens.
let me know if you find a better way of doing the same.
And while I was at it, so I also made some ui changes to these cards to make the ui look as close as possible to the Figma design.
Video
Record_2025-09-02-04-11-45_026f621985d6cfa1a169c52d305dc178.mp4
Images