feat: Share accounts UI #2495
feat: Share accounts UI #2495
Conversation
| MifosScaffold( | ||
| title = "Share Accounts", | ||
| onBackPressed = {}, | ||
| ) { paddingValues -> |
There was a problem hiding this comment.
move share Accounts to string Resources and why onBackPressed is empty
There was a problem hiding this comment.
look in figma, thats not the scaffold we will be using, its just here for the time being.
| } | ||
|
|
||
| ShareAccountsUiState.DialogState.Loading -> MifosCircularProgress() | ||
| null -> {} |
There was a problem hiding this comment.
in the recent previous prs review conversation it is decided not to place CircularProgressbar inside dialog state
create another internal state and if it is Loading show loader , if success show screen
like in #2491
| ShareAccountsAction.ToggleFiler -> { | ||
| mutableStateFlow.update { | ||
| it.copy( | ||
| isFilterActive = !state.isFilterActive, |
There was a problem hiding this comment.
create handle functions for each and don't update it in handleaction
use like
is NewLoanAccountAction.DismissDialog -> handleDismissAddCollateralDialog()
private fun handleDismissAddCollateralDialog() {
mutableStateFlow.update { it.copy(dialogState = null) }
}
itsPronay
force-pushed
the
share_accounts_final
branch
from
d04c7c8 to
52dba9e
Compare
itsPronay
force-pushed
the
share_accounts_final
branch
from
7aa9d36 to
a7f0531
Compare
3 participants
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-574
