refactor: migrate feature/update-password to CMP#2802
refactor: migrate feature/update-password to CMP#2802niyajali merged 9 commits intoopenMF:kmp-implfrom
Conversation
...sword/src/commonMain/kotlin/org/mifos/mobile/feature/update/password/UpdatePasswordScreen.kt
Outdated
Show resolved
Hide resolved
|
@itsPronay upload image for android |
...word/src/commonMain/kotlin/org/mifos/mobile/feature/update/password/UpdatePasswordContent.kt
Outdated
Show resolved
Hide resolved
niyajali
left a comment
There was a problem hiding this comment.
@itsPronay all states related logic, lamdas, validation logic always should be handled in ViewModel not in UI code. UI is only for showing the content all actions/event should be handled in ViewModel, Move all these types of things on there and use that directly from ViewModel.
And you're about to fix the app build issue on android -client, did you fixed? App is running as expected!
...word/src/commonMain/kotlin/org/mifos/mobile/feature/update/password/UpdatePasswordContent.kt
Outdated
Show resolved
Hide resolved
...word/src/commonMain/kotlin/org/mifos/mobile/feature/update/password/UpdatePasswordContent.kt
Outdated
Show resolved
Hide resolved
|
@itsPronay let me know after this changes, we'll proceed with merge |
On it @niyajali bhaiya... I was moved here to help Arjun with the migration |
Fixes - https://mifosforge.jira.com/browse/MM-212
video_2025-03-09_20-38-31.mp4
Please Add Screenshots If there are any UI changes.
| Before | After |
|--------------------------------------------|----------------------------------------|
| | |
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.