Skip to content

refactor: migrate feature/update-password to CMP#2802

Merged
niyajali merged 9 commits intoopenMF:kmp-implfrom
itsPronay:update_password_kmp
Mar 9, 2025
Merged

refactor: migrate feature/update-password to CMP#2802
niyajali merged 9 commits intoopenMF:kmp-implfrom
itsPronay:update_password_kmp

Conversation

@itsPronay
Copy link
Contributor

@itsPronay itsPronay commented Mar 7, 2025

Fixes - https://mifosforge.jira.com/browse/MM-212

video_2025-03-09_20-38-31.mp4

image
image

Please Add Screenshots If there are any UI changes.

| Before | After |

|--------------------------------------------|----------------------------------------|
| | |

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@itsPronay itsPronay changed the title Update password kmp refactor: migrate feature/update-password to CMP Mar 7, 2025
@Nagarjuna0033
Copy link
Contributor

@itsPronay upload image for android

@itsPronay itsPronay requested a review from Nagarjuna0033 March 8, 2025 08:03
Copy link
Collaborator

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsPronay all states related logic, lamdas, validation logic always should be handled in ViewModel not in UI code. UI is only for showing the content all actions/event should be handled in ViewModel, Move all these types of things on there and use that directly from ViewModel.

And you're about to fix the app build issue on android -client, did you fixed? App is running as expected!

@niyajali
Copy link
Collaborator

niyajali commented Mar 8, 2025

@itsPronay let me know after this changes, we'll proceed with merge

@itsPronay
Copy link
Contributor Author

@itsPronay all states related logic, lamdas, validation logic always should be handled in ViewModel not in UI code. UI is only for showing the content all actions/event should be handled in ViewModel, Move all these types of things on there and use that directly from ViewModel.

And you're about to fix the app build issue on android -client, did you fixed? App is running as expected!

On it @niyajali bhaiya...

I was moved here to help Arjun with the migration

@niyajali niyajali merged commit 540705e into openMF:kmp-impl Mar 9, 2025
7 checks passed
Nagarjuna0033 pushed a commit to Nagarjuna0033/mifos-mobile that referenced this pull request May 12, 2025
Samriddhi743 pushed a commit to Samriddhi743/mifos-mobile that referenced this pull request Oct 3, 2025
Naman-kr404 pushed a commit to Naman-kr404/mifos-mobile that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants