fix(loan-account): Set fixed height for label value card

[markrizkalla]

Changed defaultMinSize to a fixed height for the MifosLabelValueCard in the loan account details screen.

Fixes - Jira-#MM-552

Please Add Screenshots If there are any UI changes.

Before	After

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

• Style
  • Refined card layout rendering in the Loan Account Details screen for improved visual consistency.

[coderabbitai]

📝 Walkthrough

Walkthrough

A layout modifier in LoanAccountDetailsScreen was changed from defaultMinSize(minHeight = DesignToken.sizes.cardDp64) to height(DesignToken.sizes.cardDp64) on the AccountDetailsGrid component, altering how the card enforces its vertical size constraint.

Changes

Cohort / File(s)	Summary
Compose Layout Modifier Update feature/loan-account/src/commonMain/kotlin/org/mifos/mobile/feature/loanaccount/loanAccountDetails/LoanAccountDetailsScreen.kt	Replaced defaultMinSize(minHeight = ...) with height(...) for AccountDetailsGrid vertical sizing constraint; updated corresponding imports.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• MM-542 loan account details doesnt render properly the values in the button table #3083: Directly modifies the same MifosLabelValueCard modifier in LoanAccountDetailsScreen, reversing this change by switching height back to defaultMinSize.
• fix(ui): fix account status is being cut & standardize status color #3047: Also alters card height behavior in AccountDetailsGrid by switching to heightIn(min = ...) approach.

Suggested reviewers

• niyajali
• Nagarjuna0033
• biplab1

Poem

🐰 A modifier hops and bounds,
From default to height, no frowns,
The card now stands with fixed delight,
No longer stretching, sized just right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing defaultMinSize with a fixed height modifier for the MifosLabelValueCard in the loan account details screen.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

feature/loan-account/src/commonMain/kotlin/org/mifos/mobile/feature/loanaccount/loanAccountDetails/LoanAccountDetailsScreen.kt (1)

248-251: Fixed height may clip content under accessibility font scaling.

Switching from defaultMinSize(minHeight = …) to height(…) fixes the overflow shown in the screenshots, but it also prevents the card from growing when content is taller — e.g., with large/extra-large accessibility font sizes or longer translated strings. If clipping becomes an issue, consider Modifier.heightIn(min = DesignToken.sizes.cardDp64, max = <reasonable_max>) to bound growth without hard-clipping.

That said, the fix clearly improves the current UI — fine to ship and revisit if accessibility testing surfaces issues.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}