Skip to content

MX-238: Implement externalAuthorizationToken used for the registration#143

Merged
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop
Apr 13, 2026
Merged

MX-238: Implement externalAuthorizationToken used for the registration#143
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop

Conversation

@IOhacker
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker commented Apr 13, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed token length configuration handling to ensure that custom-configured token length values are properly recognized and applied by the authentication system. Previously, configuration property overrides were not being correctly processed, causing the system to unexpectedly fall back to default token length values instead of using configured settings.

@IOhacker IOhacker merged commit d72cf44 into openMF:develop Apr 13, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 361d1762-9713-4799-bf0d-346a92dd29f2

📥 Commits

Reviewing files that changed from the base of the PR and between 9834ceb and 53b5e35.

📒 Files selected for processing (1)
  • src/main/java/org/apache/fineract/selfservice/registration/service/SelfServiceAuthorizationTokenService.java

📝 Walkthrough

Walkthrough

Fixed configuration property key resolution in token length initialization by correcting the misspelled fallback key from mifos.self.service.token.lenght to mifos.self.service.token.length, ensuring the configured property is properly applied.

Changes

Cohort / File(s) Summary
Configuration Property Typo Fix
src/main/java/org/apache/fineract/selfservice/registration/service/SelfServiceAuthorizationTokenService.java
Corrected misspelled configuration property key in fallback logic; changed mifos.self.service.token.lenght to mifos.self.service.token.length to ensure proper token length configuration resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

⏱️ <10 Min Review

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant