WEB-316: Advance Accounting for loan transaction classification

[alberto-art3ch]

Description

There was an issue in the Advance Accounting mapping for the Loan transaction classification

WEB-316

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Refactor
  • Improved type safety and reliability for GL account lookups in advanced accounting mapping rules.
  • Enhances data consistency and validation during configuration, reducing risk of errors in edge cases.
  • No changes to UI or user workflows — behavior and interfaces remain the same.

[coderabbitai]

Walkthrough

The component updates the getGlAccountData method to return a typed GLAccount | null, adds the GLAccount import, renames glAccountData to glAccountDatas, and changes the lookup logic to iterate and return the matching GLAccount or null if not found.

Changes

Cohort / File(s)	Summary
Type tightening for GLAccount retrieval src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts	Add import GLAccount; change getGlAccountData(valueId: number) return type to `GLAccount

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly references the relevant Jira ticket and succinctly describes the main change, which is updating the advance accounting mapping for loan transaction classification, directly aligning with the PR objectives and code modifications.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4effd0 and b1452bd.

📒 Files selected for processing (1)

• src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19ebe4d and d4effd0.

📒 Files selected for processing (1)

• src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

• src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts

🧬 Code graph analysis (1)

src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts (1)

src/app/shared/models/general.model.ts (1)

• GLAccount (13-24)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

🔇 Additional comments (1)

src/app/products/loan-products/loan-product-stepper/loan-product-accounting-step/advanced-accounting-mapping-rule/advanced-accounting-mapping-rule.component.ts (1)

24-24: LGTM!

The GLAccount import properly introduces strict typing for GL account data.

[gkbishnoi07]

LGTM