WEB-450 Days from field allows negative and zero values in delinquency range creation form

[JaySoni1]

Changes Made :-

-Fixed validation issue for "Days From" field in Delinquency Range creation form.

WEB-450

Before :-

After :-

Summary by CodeRabbit

• Bug Fixes
  • Improved validation for the minimum age input: now enforces a positive value, shows a clear "must be a positive number" error for invalid entries, while keeping the existing required check and messages intact.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Adds client-side validation to the minimumAgeDays input in the create-range component template: sets min="1" and adds a mat-error for pattern validation while keeping the required validation intact.

Changes

Cohort / File(s)	Summary
Form Input Validation src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html	Adds min="1" to the minimumAgeDays input; introduces a mat-error for pattern validation ("must be a positive number"); retains existing required validation and message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single-file, small template change
• Items to spot-check:
  • Ensure min="1" matches business rules and doesn't conflict with any model-level validation
  • Verify the pattern validator and error message localization/consistency with other messages

Suggested reviewers

• alberto-art3ch
• gkbishnoi07

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding validation to prevent negative and zero values in the 'Days From' field of the delinquency range creation form.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d48c6bd and 26fe0aa.

📒 Files selected for processing (1)

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ded425 and d48c6bd.

📒 Files selected for processing (1)

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

🔇 Additional comments (1)

src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html (1)

17-17: ✓ Client-side constraint enforced.

The min="1" attribute correctly prevents negative and zero values, addressing the PR objective.

[IOhacker]

LGTM

[JaySoni1]

@IOhacker Thank You for the review