Skip to content

WEB-617: Fix account field alignment#3037

Merged
IOhacker merged 1 commit into
openMF:devfrom
AnvayKharb:WEB-617-account-alignment
Jan 22, 2026
Merged

WEB-617: Fix account field alignment#3037
IOhacker merged 1 commit into
openMF:devfrom
AnvayKharb:WEB-617-account-alignment

Conversation

@AnvayKharb
Copy link
Copy Markdown
Contributor

@AnvayKharb AnvayKharb commented Jan 22, 2026

Fixes improper alignment of the Account field to match the Financial Activity field.
Changes are limited to alignment only.

BEFORE

Screenshot 2026-01-21 at 9 37 36 PM

AFTER

Screenshot 2026-01-22 at 5 05 11 PM

Summary by CodeRabbit

  • Style
    • Improved layout spacing in the financial activity mapping component for better visual alignment and presentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 22, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Adds a CSS rule to remove right margin from layout-column elements within the mifosx-gl-account-selector component using deep styling. This is a styling-only change affecting component layout spacing without functional modifications.

Changes

Cohort / File(s) Summary
Styling adjustment
src/app/accounting/financial-activity-mappings/create-financial-activity-mapping/create-financial-activity-mapping.component.scss
Adds ::ng-deep CSS rule to remove right margin (margin-right: 0) for layout-column elements inside mifosx-gl-account-selector

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • alberto-art3ch
  • IOhacker
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'WEB-617: Fix account field alignment' directly matches the PR's objective to fix the alignment of the Account field to match the Financial Activity field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@IOhacker
Copy link
Copy Markdown
Contributor

@shubhamkumar9199 could you please give us feedback?

@shubhamkumar9199
Copy link
Copy Markdown
Contributor

shubhamkumar9199 commented Jan 22, 2026

@AnvayKharb here are several forms with the same structure. Could you please check whether this issue exists in other forms as well? If so, try implementing the fix in main.scss so it applies consistently.

@AnvayKharb
Copy link
Copy Markdown
Contributor Author

Hi @IOhacker @shubhamkumar9199 Thanks for the review. As per my understanding, all forms are functioning correctly; only alignment issue was present here.

@IOhacker
Copy link
Copy Markdown
Contributor

@AnvayKharb could you please double check :)

Copy link
Copy Markdown
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@IOhacker IOhacker merged commit 70d1361 into openMF:dev Jan 22, 2026
5 checks passed
@AnvayKharb
Copy link
Copy Markdown
Contributor Author

@IOhacker yes sir i have checked . thanks for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants