WEB-617: Fix account field alignment#3037
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Styling adjustment src/app/accounting/financial-activity-mappings/create-financial-activity-mapping/create-financial-activity-mapping.component.scss |
Adds ::ng-deep CSS rule to remove right margin (margin-right: 0) for layout-column elements inside mifosx-gl-account-selector |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested reviewers
- alberto-art3ch
- IOhacker
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'WEB-617: Fix account field alignment' directly matches the PR's objective to fix the alignment of the Account field to match the Financial Activity field. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
|
@shubhamkumar9199 could you please give us feedback? |
|
@AnvayKharb here are several forms with the same structure. Could you please check whether this issue exists in other forms as well? If so, try implementing the fix in main.scss so it applies consistently. |
|
Hi @IOhacker @shubhamkumar9199 Thanks for the review. As per my understanding, all forms are functioning correctly; only alignment issue was present here. |
|
@AnvayKharb could you please double check :) |
|
@IOhacker yes sir i have checked . thanks for review |
Fixes improper alignment of the Account field to match the Financial Activity field.
Changes are limited to alignment only.
BEFORE
AFTER
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.