WEB-791: Financial Translation to Mexican Spanish#3227
Merged
IOhacker merged 1 commit intoopenMF:devfrom Feb 25, 2026
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Spanish Translation Updates src/assets/translations/es-MX.json |
Modified ~82 translation entries: replaced "Office" → "Sucursal", "garante" → "aval", "laborables" → "laborales", and adjusted related phrases in menus, dialogs, labels, audit texts, import/export descriptions, and help strings. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
- IOhacker
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'WEB-791: Financial Translation to Mexican Spanish' clearly describes the main change in the pull request, which is updating Spanish translations (es-MX.json) with Mexican Spanish terminology. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (1)
src/assets/translations/es-MX.json (1)
2300-2300: Add missing preposition for natural Spanish.Line [2300] reads unnaturally as “Datos Sucursal matriz”.
💡 Suggested fix
- "Parent officeData": "Datos Sucursal matriz", + "Parent officeData": "Datos de la sucursal matriz",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 2300, The translation for the key "Parent officeData" is missing a preposition and reads unnaturally; update the value for "Parent officeData" in src/assets/translations/es-MX.json to a natural Spanish phrase such as "Datos de la sucursal matriz" (or "Datos de la oficina matriz" if "oficina" matches your terminology) so the entry reads correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/es-MX.json`:
- Line 1169: The translation for the key "Manage Holidays" is not
action-oriented; update both occurrences of the "Manage Holidays" entry (the
JSON key "Manage Holidays") to an action-form Spanish translation such as
"Administrar días festivos" (matching nearby "Administrar …" entries) so the
intent remains consistent across the file.
- Line 492: The translation for the key "Import Offices" is inconsistent: one
entry uses "Sucursales de Importación" and another uses "Importar Sucursales";
standardize both to the action-oriented form "Importar Sucursales" by replacing
the value "Sucursales de Importación" (the existing value for "Import Offices")
so every "Import Offices" entry uses "Importar Sucursales".
- Line 2027: The translation value for the key "Is Dependent" is missing the
closing question mark; update the JSON entry for "Is Dependent" (the value
string) to include the closing interrogative punctuation (change "¿Es
dependiente" to "¿Es dependiente?") so the Spanish question is properly closed.
- Line 3425: Update the Spanish translation for the key "Mifos X data-tables
allow the user to add custom fields" to use the correct conjunction by replacing
"u sucursal" with "o sucursal" so the sentence reads "...grupo, centro o
sucursal."; locate the JSON entry with that key in
src/assets/translations/es-MX.json and make the text change.
- Line 2172: Update the translation value for the JSON key "Minimum Guarantee
from Guarantor Funds(%)" to a grammatically correct Spanish phrase; replace
"Garantía Mínima de Fondos Avales(%)" with a clearer version such as "Porcentaje
de garantía mínima de fondos de aval (%)" (or "Garantía mínima de los fondos del
avalador (%)") so the label reads naturally in Spanish.
- Line 2244: The translation for the key "Office Name" currently reads
"Sucursal" which drops the "Name" meaning; update the value for the "Office
Name" key in the es-MX JSON to preserve the name aspect (e.g., "Nombre de la
sucursal" or "Nombre de la oficina") so forms keep the correct label meaning.
- Line 1212: The Spanish value for the key "Recover from Guarantor" uses a
reflexive form ("Recuperarse del aval"); change it to a non-reflexive
imperative/infinitive action form such as "Recuperar del aval" (replace the
value for the "Recover from Guarantor" key accordingly) so it reads as an
operation rather than self-recovery.
---
Nitpick comments:
In `@src/assets/translations/es-MX.json`:
- Line 2300: The translation for the key "Parent officeData" is missing a
preposition and reads unnaturally; update the value for "Parent officeData" in
src/assets/translations/es-MX.json to a natural Spanish phrase such as "Datos de
la sucursal matriz" (or "Datos de la oficina matriz" if "oficina" matches your
terminology) so the entry reads correctly.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
src/assets/translations/es-MX.json (4)
2027-2027:⚠️ Potential issue | 🟡 MinorClose interrogative punctuation.
Line [2027] opens a question but does not close it.
💡 Suggested fix
- "Is Dependent": "¿Es dependiente", + "Is Dependent": "¿Es dependiente?",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 2027, The Spanish translation for the key "Is Dependent" is missing the closing question mark; update the value string for "Is Dependent" to include the closing inverted question mark at the end (e.g., "¿Es dependiente?") so the interrogative is properly closed in src/assets/translations/es-MX.json.
3406-3406:⚠️ Potential issue | 🟡 MinorKeep “Manage Holidays” action-oriented in this section.
Line [3406] drops the “Manage” intent by using only “Días festivos”.
💡 Suggested fix
- "Manage Holidays": "Días festivos", + "Manage Holidays": "Administrar días festivos",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 3406, The translation for the key "Manage Holidays" lost the action intent; update the value for the JSON key "Manage Holidays" in src/assets/translations/es-MX.json to an action-oriented phrase (e.g., "Administrar días festivos" or "Gestionar días festivos") so it preserves the original "Manage" intent; locate the string "Manage Holidays" and replace its value accordingly.
492-492:⚠️ Potential issue | 🟡 MinorStandardize duplicate translation for “Import Offices”.
Line [492] uses “Importación de Sucursales” while Line [1108] uses “Importar Sucursales” for the same source key, which creates inconsistent UX.
💡 Suggested fix
- "Import Offices": "Importación de Sucursales", + "Import Offices": "Importar Sucursales",Also applies to: 1108-1108
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 492, The translation for the source key "Import Offices" is inconsistent: update both occurrences of the "Import Offices" entry in the es-MX JSON so they use the same Spanish phrase (choose either "Importación de Sucursales" or "Importar Sucursales") to standardize UX; locate the two entries for the key "Import Offices" in src/assets/translations/es-MX.json (the duplicate occurrences) and replace one so both values match exactly.
2172-2172: Refine guarantor-funds wording to avoid redundancy.Line [2172] repeats “garantía” in a way that reads awkwardly.
💡 Suggested tweak
- "Minimum Guarantee from Guarantor Funds(%)": "Garantía Mínima de Fondos de Garantía(%)", + "Minimum Guarantee from Guarantor Funds(%)": "Garantía mínima de fondos de aval (%)",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 2172, The Spanish translation for the key "Minimum Guarantee from Guarantor Funds(%)" reads redundant; update the value for that key to a more natural phrase such as "Garantía mínima de fondos de aval (%)" or "Porcentaje mínimo garantizado por fondos de aval (%)" to avoid repeating "garantía" and improve readability; locate the key "Minimum Guarantee from Guarantor Funds(%)" in src/assets/translations/es-MX.json and replace the current value accordingly.
🧹 Nitpick comments (2)
src/assets/translations/es-MX.json (2)
2244-2244: Use a more natural label for “Office Name”.Line [2244] is understandable, but “Nombre de la sucursal” reads more naturally than “Nombre de Sucursal”.
💡 Suggested tweak
- "Office Name": "Nombre de Sucursal", + "Office Name": "Nombre de la sucursal",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 2244, Update the translation entry for the key "Office Name" in src/assets/translations/es-MX.json by replacing its current value "Nombre de Sucursal" with the more natural Spanish phrasing "Nombre de la sucursal"; locate the JSON entry with the exact key "Office Name" and change the quoted string on the right-hand side to "Nombre de la sucursal".
3035-3035: Clean up duplicated phrasing in help text.Line [3035] repeats “o modificar”, which makes the sentence clunky.
💡 Suggested tweak
- "Add new office or modify or deactivate office": "Agregar nueva sucursal o modificar o desactivar sucursal o modificar jerarquía", + "Add new office or modify or deactivate office": "Agregar una nueva sucursal, modificarla, desactivarla o ajustar su jerarquía",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/es-MX.json` at line 3035, The translation value for the key "Add new office or modify or deactivate office" contains a duplicated phrase ("o modificar"); update the value to a clean, non-redundant Spanish sentence such as "Agregar nueva sucursal, modificar o desactivar sucursal" (or equivalent concise wording) so the help text reads smoothly; edit the value for that key in src/assets/translations/es-MX.json accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/es-MX.json`:
- Around line 1146-1147: The Spanish translations for the keys "Loan Delinquency
Tags" and "Loan Delinquency Installment Tags" (and the duplicate at the other
occurrence around the key at line ~1740) incorrectly use "Clasificación", which
alters the meaning; update their values to use a term that preserves "Tags"
(e.g., "Etiquetas de morosidad de créditos" and "Etiquetas de morosidad de
cuotas" or similar) so the JSON keys "Loan Delinquency Tags" and "Loan
Delinquency Installment Tags" reflect the original intent.
- Line 3678: The Spanish translation for the key "Working days and configure
behaviour of payments" incorrectly narrows "working days" to "días festivos";
update the value to a broader phrase that covers all non-working days (e.g., use
"días no laborables", or "feriados y otros días no laborables") so the message
reflects behavior on any non-working day rather than only holidays—replace the
current value string accordingly.
---
Duplicate comments:
In `@src/assets/translations/es-MX.json`:
- Line 2027: The Spanish translation for the key "Is Dependent" is missing the
closing question mark; update the value string for "Is Dependent" to include the
closing inverted question mark at the end (e.g., "¿Es dependiente?") so the
interrogative is properly closed in src/assets/translations/es-MX.json.
- Line 3406: The translation for the key "Manage Holidays" lost the action
intent; update the value for the JSON key "Manage Holidays" in
src/assets/translations/es-MX.json to an action-oriented phrase (e.g.,
"Administrar días festivos" or "Gestionar días festivos") so it preserves the
original "Manage" intent; locate the string "Manage Holidays" and replace its
value accordingly.
- Line 492: The translation for the source key "Import Offices" is inconsistent:
update both occurrences of the "Import Offices" entry in the es-MX JSON so they
use the same Spanish phrase (choose either "Importación de Sucursales" or
"Importar Sucursales") to standardize UX; locate the two entries for the key
"Import Offices" in src/assets/translations/es-MX.json (the duplicate
occurrences) and replace one so both values match exactly.
- Line 2172: The Spanish translation for the key "Minimum Guarantee from
Guarantor Funds(%)" reads redundant; update the value for that key to a more
natural phrase such as "Garantía mínima de fondos de aval (%)" or "Porcentaje
mínimo garantizado por fondos de aval (%)" to avoid repeating "garantía" and
improve readability; locate the key "Minimum Guarantee from Guarantor Funds(%)"
in src/assets/translations/es-MX.json and replace the current value accordingly.
---
Nitpick comments:
In `@src/assets/translations/es-MX.json`:
- Line 2244: Update the translation entry for the key "Office Name" in
src/assets/translations/es-MX.json by replacing its current value "Nombre de
Sucursal" with the more natural Spanish phrasing "Nombre de la sucursal"; locate
the JSON entry with the exact key "Office Name" and change the quoted string on
the right-hand side to "Nombre de la sucursal".
- Line 3035: The translation value for the key "Add new office or modify or
deactivate office" contains a duplicated phrase ("o modificar"); update the
value to a clean, non-redundant Spanish sentence such as "Agregar nueva
sucursal, modificar o desactivar sucursal" (or equivalent concise wording) so
the help text reads smoothly; edit the value for that key in
src/assets/translations/es-MX.json accordingly.
Comment on lines
+1146
to
+1147
| "Loan Delinquency Tags": "Clasificación de morosidad de Créditos", | ||
| "Loan Delinquency Installment Tags": "Clasificación de morosidad de cuotas", |
There was a problem hiding this comment.
“Tags” meaning was changed to “Clasificación”.
Lines [1146-1147] and Line [1740] translate “Tags” as “Clasificación”, which changes the functional meaning of the label.
💡 Suggested fix
- "Loan Delinquency Tags": "Clasificación de morosidad de Créditos",
+ "Loan Delinquency Tags": "Etiquetas de morosidad de créditos",
- "Loan Delinquency Installment Tags": "Clasificación de morosidad de cuotas",
+ "Loan Delinquency Installment Tags": "Etiquetas de morosidad de cuotas",
- "Delinquency Tags": "Clasificación de morosidad",
+ "Delinquency Tags": "Etiquetas de morosidad",Also applies to: 1740-1740
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/assets/translations/es-MX.json` around lines 1146 - 1147, The Spanish
translations for the keys "Loan Delinquency Tags" and "Loan Delinquency
Installment Tags" (and the duplicate at the other occurrence around the key at
line ~1740) incorrectly use "Clasificación", which alters the meaning; update
their values to use a term that preserves "Tags" (e.g., "Etiquetas de morosidad
de créditos" and "Etiquetas de morosidad de cuotas" or similar) so the JSON keys
"Loan Delinquency Tags" and "Loan Delinquency Installment Tags" reflect the
original intent.
| "Working days and configure behaviour of payments": "Defina días laborables y configure el comportamiento de los pagos vencidos en días festivos.", | ||
| "Working days page allows you to define which days": "La página de días laborables le permite definir qué días de la semana son días laborables.", | ||
| "Working Days": "Días laborales", | ||
| "Working days and configure behaviour of payments": "Defina días laborales y configure el comportamiento de los pagos vencidos en días festivos.", |
There was a problem hiding this comment.
Avoid narrowing “working days” to only holidays.
Line [3678] says “días festivos”, but the key is about working-days behavior in general (including non-working days beyond holidays).
💡 Suggested fix
- "Working days and configure behaviour of payments": "Defina días laborales y configure el comportamiento de los pagos vencidos en días festivos.",
+ "Working days and configure behaviour of payments": "Defina los días laborales y configure el comportamiento de los pagos vencidos en días no laborables.",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/assets/translations/es-MX.json` at line 3678, The Spanish translation for
the key "Working days and configure behaviour of payments" incorrectly narrows
"working days" to "días festivos"; update the value to a broader phrase that
covers all non-working days (e.g., use "días no laborables", or "feriados y
otros días no laborables") so the message reflects behavior on any non-working
day rather than only holidays—replace the current value string accordingly.
Nightwing-77
pushed a commit
to Nightwing-77/web-app
that referenced
this pull request
Mar 2, 2026
changed node/nginx versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WEB-791: Financial Translation to Mexican Spanish
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit