WEB-634-The dashboard menu should display the full credit traceability#3230
Merged
IOhacker merged 1 commit intoopenMF:devfrom Feb 25, 2026
Merged
WEB-634-The dashboard menu should display the full credit traceability#3230IOhacker merged 1 commit intoopenMF:devfrom
IOhacker merged 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Loan Dashboard Chart Visualization src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts |
Added fallback to principalOriginalDue / interestOriginalDue when building period data. Replaced slicing of payments chart labels/data so full arrays are used. Set x-axis tick fontSize 10, maxRotation/minRotation to 45, and autoSkip: false to show all labels. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | The title mentions 'credit traceability' but the actual changes focus on loan dashboard chart improvements—fallback data sourcing, expanded payment chart data display, and axis styling adjustments. | Update the title to reflect the actual changes, such as 'Fix Loan Dashboard Chart display by expanding payment data and adjusting axis styling' or similar. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts (1)
296-300: Consider adaptive tick skipping for long repayment schedules.At Line 298-Line 300, fixed rotation +
autoSkip: falsecan make long schedules very dense and hard to read. Consider toggling skip/rotation based onlabels.lengthso short schedules stay fully visible while long ones remain usable.♻️ Suggested adjustment
+ const denseLabels = labels.length > 24; ... ticks: { font: { size: 10 }, - maxRotation: 45, - minRotation: 45, - autoSkip: false + maxRotation: denseLabels ? 45 : 0, + minRotation: denseLabels ? 45 : 0, + autoSkip: denseLabels, + maxTicksLimit: denseLabels ? 24 : undefined }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts` around lines 296 - 300, The X axis config in loan-account-dashboard.component.ts currently forces maxRotation/minRotation and autoSkip: false which makes long repayment schedules unreadable; update the axis/tick logic (where you build the chart options for the chart instance / method that sets ticks) to inspect labels.length and apply adaptive settings: for small label counts keep autoSkip: false and fixed rotations, but for larger label counts enable autoSkip: true and reduce maxRotation/minRotation (or set them to 0/30) so ticks skip and rotate less; reference the tick config block that contains maxRotation, minRotation and autoSkip when implementing this conditional adjustment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts`:
- Around line 224-225: The pushes to principalData and interestData use the ||
operator which treats 0 as falsy and causes incorrect fallbacks; update the
expressions in loan-account-dashboard.component.ts (the principalData.push and
interestData.push calls) to use nullish coalescing (??) so they only fall back
when the value is null or undefined (e.g., use period.principalDue ??
period.principalOriginalDue ?? 0 and period.interestDue ??
period.interestOriginalDue ?? 0) to preserve legitimate zero values.
---
Nitpick comments:
In
`@src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts`:
- Around line 296-300: The X axis config in loan-account-dashboard.component.ts
currently forces maxRotation/minRotation and autoSkip: false which makes long
repayment schedules unreadable; update the axis/tick logic (where you build the
chart options for the chart instance / method that sets ticks) to inspect
labels.length and apply adaptive settings: for small label counts keep autoSkip:
false and fixed rotations, but for larger label counts enable autoSkip: true and
reduce maxRotation/minRotation (or set them to 0/30) so ticks skip and rotate
less; reference the tick config block that contains maxRotation, minRotation and
autoSkip when implementing this conditional adjustment.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/loans/loans-view/loan-account-dashboard/loan-account-dashboard.component.ts
JaySoni1
force-pushed
the
loan-dashboard-traceability
branch
from
4fe7ce5 to
4961512
Compare
Contributor
Author
|
@IOhacker Thank You for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made :-
WEB-634
Summary by CodeRabbit
Bug Fixes
Style