Skip to content

WEB-805:Upgrade the Docker Image versions for NodeJS and Nginx#3247

Merged
IOhacker merged 1 commit intoopenMF:devfrom
Nightwing-77:dockerfile
Mar 2, 2026
Merged

WEB-805:Upgrade the Docker Image versions for NodeJS and Nginx#3247
IOhacker merged 1 commit intoopenMF:devfrom
Nightwing-77:dockerfile

Conversation

@Nightwing-77
Copy link
Copy Markdown
Contributor

@Nightwing-77 Nightwing-77 commented Mar 2, 2026

Description
-modified nginx/node versions in the dockerfile

jira ticket: 805

Please make sure these boxes are checked before submitting your pull request - thanks!

[*] If you have multiple commits please combine them into one commit by squashing them.

[*] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Chores
    • Updated base container images to newer Alpine patch releases to improve security, reliability, and compatibility. These runtime image updates apply to both build and web-serving stages, include minor upstream package/security fixes, and are non-functional changes that should not affect application behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 2, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a14872a and 73af5a3.

📒 Files selected for processing (1)
  • Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

Walkthrough

The Dockerfile ARGs for base images were updated: BUILDER_IMAGE changed from node:24-alpine3.22 to node:24-alpine3.23, and NGINX_IMAGE changed from nginx:1.29-alpine3.22-slim to nginx:1.29-alpine3.23-slim. No build logic or structure changes.

Changes

Cohort / File(s) Summary
Dockerfile base image updates
Dockerfile
Updated ARG BUILDER_IMAGE from node:24-alpine3.22node:24-alpine3.23 and ARG NGINX_IMAGE from nginx:1.29-alpine3.22-slimnginx:1.29-alpine3.23-slim.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • IOhacker
  • steinwinde
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: upgrading Docker image versions for NodeJS and Nginx, which aligns perfectly with the Dockerfile modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

4-5: Pin the upgraded base images by digest for reproducible builds.

The tag upgrade on Line 4 and Line 5 looks good, but tags can be retargeted. Consider pinning both images with @sha256 to avoid drift across builds.

#!/bin/bash
set -euo pipefail

# Resolve current digests for the exact tags used in Dockerfile (read-only).
for image in "node:24-alpine3.23" "nginx:1.29-alpine3.23-slim"; do
  repo="${image%:*}"
  tag="${image##*:}"

  token=$(curl -fsSL \
    "https://auth.docker.io/token?service=registry.docker.io&scope=repository:library/${repo}:pull" \
    | jq -r '.token')

  digest=$(curl -fsSI \
    -H "Authorization: Bearer ${token}" \
    -H "Accept: application/vnd.oci.image.index.v1+json, application/vnd.docker.distribution.manifest.list.v2+json" \
    "https://registry-1.docker.io/v2/library/${repo}/manifests/${tag}" \
    | awk -F': ' 'tolower($1)=="docker-content-digest"{gsub("\r","",$2); print $2}')

  echo "${image}@${digest}"
done
Example follow-up diff after resolving digests
-ARG BUILDER_IMAGE=node:24-alpine3.23
-ARG NGINX_IMAGE=nginx:1.29-alpine3.23-slim
+ARG BUILDER_IMAGE=node:24-alpine3.23@sha256:<resolved-node-digest>
+ARG NGINX_IMAGE=nginx:1.29-alpine3.23-slim@sha256:<resolved-nginx-digest>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 4 - 5, Update the two Dockerfile ARGs to use
immutable image digests instead of floating tags: replace the values for ARG
BUILDER_IMAGE and ARG NGINX_IMAGE (currently "node:24-alpine3.23" and
"nginx:1.29-alpine3.23-slim") with their corresponding `@sha256` digests you
resolve (e.g., "node:24-alpine3.23@sha256:..." and
"nginx:1.29-alpine3.23-slim@sha256:...") so builds are reproducible; use the
provided registry lookup script or Docker registry API to fetch the exact
digests and commit the updated ARG lines in the Dockerfile.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Dockerfile`:
- Around line 4-5: Update the two Dockerfile ARGs to use immutable image digests
instead of floating tags: replace the values for ARG BUILDER_IMAGE and ARG
NGINX_IMAGE (currently "node:24-alpine3.23" and "nginx:1.29-alpine3.23-slim")
with their corresponding `@sha256` digests you resolve (e.g.,
"node:24-alpine3.23@sha256:..." and "nginx:1.29-alpine3.23-slim@sha256:...") so
builds are reproducible; use the provided registry lookup script or Docker
registry API to fetch the exact digests and commit the updated ARG lines in the
Dockerfile.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a396934 and a14872a.

📒 Files selected for processing (1)
  • Dockerfile

@Nightwing-77
Copy link
Copy Markdown
Contributor Author

@IOhacker hey! give it a review whenever you have time!!

@IOhacker
Copy link
Copy Markdown
Contributor

IOhacker commented Mar 2, 2026

Please squash and commit.

@Nightwing-77 Nightwing-77 reopened this Mar 2, 2026
@Nightwing-77
Copy link
Copy Markdown
Contributor Author

Nightwing-77 commented Mar 2, 2026

@IOhacker done!! i pulled the changes wrongly which cause git to think they were a part of my pr!!

Copy link
Copy Markdown
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit fe8c0ed into openMF:dev Mar 2, 2026
7 checks passed
@Nightwing-77 Nightwing-77 deleted the dockerfile branch March 2, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants