Skip to content

MX-811: Spanish translation#3252

Merged
IOhacker merged 1 commit intoopenMF:devfrom
AlejandroED21:dev
Mar 2, 2026
Merged

MX-811: Spanish translation#3252
IOhacker merged 1 commit intoopenMF:devfrom
AlejandroED21:dev

Conversation

@AlejandroED21
Copy link
Copy Markdown
Collaborator

@AlejandroED21 AlejandroED21 commented Mar 2, 2026

Description

Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Documentation
    • Updated Spanish Mexican translation labels for client name field components. Surname identifiers now display as "Primer apellido" and "Segundo apellido", with corresponding updates to middle name field terminology throughout the application.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 2, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Translation updates for Mexican Spanish locale adjusting name field labels to reflect different naming conventions (paternal/maternal structure to cardinal numbering). No functional or logic changes—text-only modifications to display labels.

Changes

Cohort / File(s) Summary
Mexican Spanish Translation Updates
src/assets/translations/es-MX.json
Updated name field translation labels: "Apellido Materno del cliente" → "Segundo apellido del cliente", "Apellido Paterno del cliente" → "Primer apellido del cliente", and corresponding Last Name/Middle Name mappings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • IOhacker
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'MX-811: Spanish translation' is vague and generic. While it references the ticket ID and a language, it doesn't clearly convey the specific changes made to the translation strings (updates to last name and middle name field labels in Mexican Spanish). Consider a more specific title like 'MX-811: Update Mexican Spanish name field labels' to better reflect the actual changes in the changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/assets/translations/es-MX.json (1)

2063-2063: Consider aligning adjacent validation/help text with the new surname terminology.
These label updates are good; as a follow-up, you may want to harmonize related unchanged strings (e.g., generic “middle name/last name” prompts or errors) to avoid mixed terminology in the UI.

Also applies to: 2168-2168

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/assets/translations/es-MX.json` at line 2063, Update related translation
keys to keep terminology consistent with the changed "Last Name" ("Segundo
apellido") entry: search for adjacent/related keys such as "Last Name", any
combined labels like "Middle Name/Last Name", "Surname", validation messages and
help text (including the entry noted around line 2168) and harmonize their
Spanish values to use "apellido" or "segundo apellido" as appropriate so the UI
doesn't mix terms; modify the corresponding JSON values for those keys to match
the new surname terminology and review any error/placeholder strings for
consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/assets/translations/es-MX.json`:
- Line 2063: Update related translation keys to keep terminology consistent with
the changed "Last Name" ("Segundo apellido") entry: search for adjacent/related
keys such as "Last Name", any combined labels like "Middle Name/Last Name",
"Surname", validation messages and help text (including the entry noted around
line 2168) and harmonize their Spanish values to use "apellido" or "segundo
apellido" as appropriate so the UI doesn't mix terms; modify the corresponding
JSON values for those keys to match the new surname terminology and review any
error/placeholder strings for consistency.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe8c0ed and 6d08038.

📒 Files selected for processing (1)
  • src/assets/translations/es-MX.json

Copy link
Copy Markdown
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit deef4a0 into openMF:dev Mar 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants