Skip to content

WEB-827: Prevent tabnabbing in window.open#3341

Merged
IOhacker merged 1 commit intoopenMF:devfrom
tkshsbcue:WEB-827/prevent-tabnabbing-window-open
Mar 9, 2026
Merged

WEB-827: Prevent tabnabbing in window.open#3341
IOhacker merged 1 commit intoopenMF:devfrom
tkshsbcue:WEB-827/prevent-tabnabbing-window-open

Conversation

@tkshsbcue
Copy link
Contributor

Description:
External links are opened using window.open(url, '_blank'). Without noopener or noreferrer, the opened page can access window.opener, creating a potential tabnabbing vulnerability.

Fix:
Update window.open calls to include 'noopener,noreferrer'

ticket -> https://mifosforge.jira.com/browse/WEB-827?atlOrigin=eyJpIjoiNjM1YmU1YjExZDlmNDk3NWJlNDhlMGY1YTRjODMzYmEiLCJwIjoiaiJ9

Add noopener,noreferrer when opening external links to prevent the
opened page from accessing window.opener (tabnabbing protection).

Made-with: Cursor
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Warning

Rate limit exceeded

@tkshsbcue has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6efbe92-b1d0-44e3-abb0-62d483114103

📥 Commits

Reviewing files that changed from the base of the PR and between b1fd0f1 and dc97b1e.

📒 Files selected for processing (1)
  • src/app/shared/tabs/entity-datatable-tab/datatable-single-row/datatable-single-row.component.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit 2c0b15d into openMF:dev Mar 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants