Skip to content

WEB-865: Add translations for permission names using ngx-translate#3389

Merged
IOhacker merged 1 commit into
openMF:devfrom
YousufFFFF:WEB-865-permission-translations
Mar 16, 2026
Merged

WEB-865: Add translations for permission names using ngx-translate#3389
IOhacker merged 1 commit into
openMF:devfrom
YousufFFFF:WEB-865-permission-translations

Conversation

@YousufFFFF

@YousufFFFF YousufFFFF commented Mar 16, 2026

Copy link
Copy Markdown
Member

Description

This pull request introduces enhancements to how permission names are displayed and searched within the Maker-Checker Tasks and View Role components. The changes leverage translation keys for more user-friendly and localized permission names, and update the search logic to use these improved names. Additionally, new translation entries for permissions have been added.

Improvements to permission name formatting and translation:

  • Added TranslateService injection and updated permissionName and formatName methods in ConfigureMakerCheckerTasksComponent and ViewRoleComponent to use translation keys for actions and entities, falling back to title-cased strings if translations are missing. This results in more readable and localized permission names throughout the UI. [1] [2] [3] [4]
  • Introduced a new titleCase helper method in both components to consistently format fallback names. [1] [2]

Enhancements to permission search functionality:

  • Updated permission search logic in ViewRoleComponent to use the improved permissionName method for more accurate and user-friendly search results. [1] [2]

Translation support:

  • Added comprehensive translation entries for permission actions and entities in en-US.json, supporting localization and improved readability of permission names.…and entity, using ngx-translate and trimming API whitespace

Related issues and discussion

#WEB-865

After Video

System.-.Google.Chrome.2026-03-16.21-53-51.mp4

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

…and entity, using ngx-translate and trimming API whitespace

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in a follow up ticket the other languages can be translated

@IOhacker IOhacker merged commit 07f8fbc into openMF:dev Mar 16, 2026
6 checks passed
@YousufFFFF

Copy link
Copy Markdown
Member Author

LGTM, in a follow up ticket the other languages can be translated

Sure I will follow the same approach for other languages too!
Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants