WEB-707 Allowing Negative Values in Loan Product Numeric Fields#3398
Open
JaySoni1 wants to merge 1 commit intoopenMF:devfrom
Open
WEB-707 Allowing Negative Values in Loan Product Numeric Fields#3398JaySoni1 wants to merge 1 commit intoopenMF:devfrom
JaySoni1 wants to merge 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Loans Account Terms Step Component src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html, loans-account-terms-step.component.ts |
Added min="0" constraint to maxOutstandingLoanBalance input field and Validators.min(0) validator to form control in both required and optional branches. |
Loan Product Settings Step Component src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html, loan-product-settings-step.component.ts |
Added min="0" attributes to multiple inputs and Validators.min(0) validators to corresponding form controls for maxTrancheCount, outstandingLoanBalance, minimumGap, maximumGap, mandatoryGuarantee, minimumGuaranteeFromOwnFunds, and minimumGuaranteeFromGuarantor. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
- WEB-569 Negative values allowed for repayment event days in loan product creation form #2984: Modifies LoanProductSettingsStepComponent to add non-negative constraints (min="0" and Validators.min(0)) to numeric form fields.
- WEB-568 Negative values allowed for arrears ageing overdue days for npa and principal threshold fields in loan product settings #2983: Adds min="0" and Validators.min(0) validators to numeric form controls in loan-product-settings-step component.
- WEB-567 Negative Values Allowed in Loan Product Setting Fields #2982: Adds Validators.min(0) and min="0" to controls in LoanProductSettingsStepComponent enforcing non-negative values.
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | The PR title states 'Allowing Negative Values' but the changes actually prevent negative values by adding min="0" validators. | Update the title to reflect the actual change, such as 'WEB-707 Prevent negative values in loan product numeric fields' to accurately represent the implementation. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
📝 Coding Plan
- Generate coding plan for human review comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
alberto-art3ch
requested changes
Mar 17, 2026
Collaborator
alberto-art3ch
left a comment
alberto-art3ch
left a comment
There was a problem hiding this comment.
Please wait to release the updated Loan Account views
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made :-
-Prevent negative values in loan product numeric input fields .
WEB-707
Before :-
After :-
Summary by CodeRabbit
Release Notes