WEB-908 Implement "Loan Reschedules" title and Localization in "Loan Reschedules" across mutiple language#3478
Merged
IOhacker merged 1 commit intoopenMF:devfrom Apr 7, 2026
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Routing Configuration src/app/loans/loans-routing.module.ts |
Added data metadata (title: "Loan Reschedules", breadcrumb: "Loan Reschedules", routeParamBreadcrumb: false) to the loan-reschedules child route. |
Translation Files - Loan Reschedules src/assets/translations/{cs-CS.json, de-DE.json, en-US.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json} |
Inserted the "Loan Reschedules" translation key with locale-specific values; minor punctuation/comma adjustments adjacent to existing "Loan Originators" entries to accommodate the new key. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- MX-811: Spanish translation #3253: Changes the same Spanish locale (
es-MX.json) and overlaps loan-related translation edits. - WEB-505 feat:implement waive penalties for loan repayment and resch… #2941: Adds or modifies similar loan-related translation keys across locale files (overlapping localization work).
Suggested reviewers
- IOhacker
- alberto-art3ch
- adamsaghy
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: implementing 'Loan Reschedules' title and its localization across multiple language files in the routing module and translation files. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/it-IT.json`:
- Line 3766: Update the Italian translation for the key "Loan Reschedules" to a
plural form instead of the current singular; replace the value "Riprogrammazione
del prestito" with a plural phrase such as "Riprogrammazioni dei prestiti" so
the translation matches the English plural key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a024027b-fb14-4b7c-bd74-6d8e37557412
📒 Files selected for processing (14)
src/app/loans/loans-routing.module.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
JaySoni1
force-pushed
the
WEB-908-missing-loan-reschedules-localization-across-multiple-language-files
branch
from
a06dcb7 to
ef60220
Compare
Contributor
Author
|
@IOhacker Thank You for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made :-
-Implement Loan Reschedules title and synchronize Loan Reschedules in multi-language translations in Loan module .
WEB-908
Before :-
After :-
Summary by CodeRabbit
New Features
Localization