WEB-913 Add export to pdf translation support for repayment schedule export button#3490
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Template Update src/app/loans/loans-view/repayment-schedule-tab/repayment-schedule-tab.component.html |
Replaced literal "Export to PDF" button text with `{{ 'labels.buttons.Export to PDF' |
Translation Files src/assets/translations/en-US.json, src/assets/translations/de-DE.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/cs-CS.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json |
Added labels.buttons["Export to PDF"] translations for English, German, French, Italian, Spanish (CL/MX), Czech, Korean, Lithuanian, Latvian, Nepali, Portuguese, and Swahili. No other keys changed. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately and specifically describes the main change: adding translation support for the 'Export to PDF' button in the repayment schedule component, which is exactly what the changeset implements. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/cs-CS.json`:
- Line 481: The Czech translation for the "Export to PDF" label is unnatural;
update the value in src/assets/translations/cs-CS.json for the "Export to PDF"
key (currently "Vývozní PDF") to a more natural CTA such as "Exportovat do PDF"
(or the shorter "Export do PDF") so the UI button reads correctly in Czech.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b34998cc-5c13-4df1-82d1-ed0f18b31a8d
📒 Files selected for processing (14)
src/app/loans/loans-view/repayment-schedule-tab/repayment-schedule-tab.component.htmlsrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
JaySoni1
force-pushed
the
WEB-913-add-export-to-pdf-translation-support-for-repayment-schedule-export-button
branch
from
b047cf6 to
341ee98
Compare
Contributor
Author
|
@IOhacker Thank You for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made :-
-Update repayment-schedule-tab component to use {{ 'labels.buttons.Export to PDF' | translate }} instead of hardcoded text for multi-language support. .
-Add "Export to PDF" translation key and translations to all 13 language files.
WEB-913
Summary by CodeRabbit