WEB-921 Restrict negative values in fixed deposits frequency and period fields#3505
Merged
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Fixed Deposit Account Settings Step src/app/deposits/fixed-deposits/fixed-deposit-account-stepper/fixed-deposit-account-settings-step/fixed-deposit-account-settings-step.component.html, fixed-deposit-account-settings-step.component.ts |
Added mifosxPositiveInteger directive to the lock-in period frequency input field. Updated TypeScript component to import PositiveIntegerDirective, changed fixedDepositAccountSettingsForm and maturityInstructionOptions fields to use definite assignment assertions, and added non-null assertions to form value access operations throughout the component. |
Fixed Deposit Account Terms Step src/app/deposits/fixed-deposits/fixed-deposit-account-stepper/fixed-deposit-account-terms-step/fixed-deposit-account-terms-step.component.html, fixed-deposit-account-terms-step.component.ts |
Added mifosxPositiveInteger directive to the deposit period input field. Updated TypeScript component to import PositiveIntegerDirective and changed fixedDepositAccountTermsForm field to use definite assignment assertion. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The pull request title accurately and specifically describes the main change: restricting negative values in fixed deposits frequency and period fields, which directly matches the changeset modifications to these input fields. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Contributor
Author
|
@alberto-art3ch Thank You for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chnages Made :-
-Fixed deposits account creation form allows negative values in Lock-in Period Frequency and Deposit Period fields .
WEB-921
Summary by CodeRabbit