Skip to content

[WEB-930] Fix correct clientStatusType.approved typo in StatusLookupPipe#3526

Merged
IOhacker merged 1 commit intoopenMF:devfrom
adity-a34:fix-status-lookup-pipe
Apr 26, 2026
Merged

[WEB-930] Fix correct clientStatusType.approved typo in StatusLookupPipe#3526
IOhacker merged 1 commit intoopenMF:devfrom
adity-a34:fix-status-lookup-pipe

Conversation

@adity-a34
Copy link
Copy Markdown
Contributor

@adity-a34 adity-a34 commented Apr 22, 2026

Description

The key clientStatusTYpe.approved (capital Y) in StatusLookupPipe never matched the API response value clientStatusType.approved, causing approved clients to always fall through to the status-unknown CSS class. This fixes the typo so approved clients render with the correct status-approved styling across all client list and detail views.

Related issues and discussion

N/A

Screenshots, if any

N/A

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a misspelling in the client approval status mapping to ensure proper CSS styling is applied when displaying client approval statuses.

JIRA ISSUE: https://mifosforge.jira.com/browse/WEB-930

Signed-off-by: Aditya Tiwari <adityatiwari342005@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Fixed a misspelled key in the status-to-CSS mapping object within the StatusLookupPipe. The key 'clientStatusTYpe.approved' was corrected to 'clientStatusType.approved', ensuring the proper input string resolves to the 'status-approved' CSS class.

Changes

Cohort / File(s) Summary
Status Pipe Typo Fix
src/app/pipes/status-lookup.pipe.ts
Corrected misspelled object key from clientStatusTYpe.approved to clientStatusType.approved in the status-to-CSS mapping within the transform() method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The pull request title accurately describes the main change: fixing a typo in the StatusLookupPipe where 'clientStatusTYpe.approved' (with capital Y) is corrected to 'clientStatusType.approved'.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adity-a34
Copy link
Copy Markdown
Contributor Author

/cc @DavidH-1
Please review!

@adity-a34 adity-a34 changed the title Fix correct clientStatusType.approved typo in StatusLookupPipe [WEB-930] Fix correct clientStatusType.approved typo in StatusLookupPipe Apr 24, 2026
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
Copy link
Copy Markdown
Contributor

@adity-a34 thank you for your efforts!

@IOhacker IOhacker merged commit ff7a5ab into openMF:dev Apr 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants