[WEB-930] Fix correct clientStatusType.approved typo in StatusLookupPipe#3526
[WEB-930] Fix correct clientStatusType.approved typo in StatusLookupPipe#3526IOhacker merged 1 commit intoopenMF:devfrom
Conversation
Signed-off-by: Aditya Tiwari <adityatiwari342005@gmail.com>
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Status Pipe Typo Fix src/app/pipes/status-lookup.pipe.ts |
Corrected misspelled object key from clientStatusTYpe.approved to clientStatusType.approved in the status-to-CSS mapping within the transform() method. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | ✅ Passed | The pull request title accurately describes the main change: fixing a typo in the StatusLookupPipe where 'clientStatusTYpe.approved' (with capital Y) is corrected to 'clientStatusType.approved'. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
|
/cc @DavidH-1 |
|
@adity-a34 thank you for your efforts! |
Description
The key
clientStatusTYpe.approved(capitalY) inStatusLookupPipenever matched the API response valueclientStatusType.approved, causing approved clients to always fall through to thestatus-unknownCSS class. This fixes the typo so approved clients render with the correctstatus-approvedstyling across all client list and detail views.Related issues and discussion
N/A
Screenshots, if any
N/A
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
JIRA ISSUE: https://mifosforge.jira.com/browse/WEB-930