WEB-657: Working Capital currency fix for multiples of

[alberto-art3ch]

Description

Working Capital issue in the currency for inMultiplesOf field marked as required

Related issues and discussion

WEB-657

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Refactor
  • Currency multiples field is now always visible and required in loan product forms, eliminating a checkbox control.
  • Installment amount multiples field is now conditionally displayed based on product type.
  • Simplified form validation and submission logic.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The loan-product-currency-step component is being refactored to remove checkbox-driven conditional validation logic. The inMultiplesOf field is now always rendered and required, while the installmentInMultiplesOf field is renamed to installmentAmountInMultiplesOf and shown conditionally based on loan product type. Form initialization and submission payload handling are updated accordingly.

Changes

Cohort / File(s)	Summary
Currency Multiples Form Simplification src/app/products/loan-products/loan-product-stepper/loan-product-currency-step/loan-product-currency-step.component.html, loan-product-currency-step.component.ts	Removes setMultiples checkbox control and conditional validation logic. Makes inMultiplesOf always rendered and required. Renames installmentInMultiplesOf to installmentAmountInMultiplesOf with conditional display based on isLoanProduct. Updates form model initialization, patching, and submission payload handling to eliminate checkbox-driven conditionals.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• WEB-632-loan-product-default-empty-multiples-fields #3084 — Both PRs modify the same currency-step component's multiples controls; one introduces setMultiples checkbox while this PR removes it and simplifies validation logic.
• WEB-916 Align Loan Product Currency Form with Product Form #3493 — Both PRs update the same component's form controls for currency and installment multiples with inverse changes to the checkbox implementation and conditional validators.

Suggested reviewers

• IOhacker
• adamsaghy

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main change: fixing the Working Capital currency issue related to the 'inMultiplesOf' field validation, which matches the core modifications made to the loan product currency step component.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[adamsaghy]

LGTM