fix(shares): correct spelling typos in transaction translations#3595
Merged
alberto-art3ch merged 1 commit intoMay 21, 2026
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Note
|
| Layer / File(s) | Summary |
|---|---|
Component and template column identifier corrections src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.ts, src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.html |
displayedColumns property updated from amountRecievedOrReturned → amountReceivedOrReturned; template column matColumnDef and header labels corrected to "Amount Received/Returned" and "Purchased/Redeemed Price". |
Translation keys synchronized across locales src/assets/translations/en-US.json, src/assets/translations/cs-CS.json, src/assets/translations/de-DE.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json |
Renamed translation keys Amount Recieved/Returned → Amount Received/Returned and Purhcased/Redeemed Price → Purchased/Redeemed Price in each locale JSON while preserving existing localized values (en-US also had BOM removal). |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The PR title accurately describes the main change: fixing spelling typos in transaction-related translations across the shares module. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 15
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/assets/translations/cs-CS.json`:
- Around line 2661-2662: Remove the duplicate JSON key "Purchased/Redeemed
Price" so only a single entry remains; locate the two identical entries for
"Purchased/Redeemed Price" in the translations object, delete one of them, and
ensure the remaining entry preserves the correct Czech value and the file stays
valid JSON (no extra commas or syntax errors).
In `@src/assets/translations/de-DE.json`:
- Around line 2663-2664: The JSON translation file contains a duplicate key
"Purchased/Redeemed Price" which causes shadowing; remove the redundant entry so
the key appears only once (keep the correct translation "Gekaufter/eingelöster
Preis"), and validate the JSON after editing; search for any other repeated keys
with the same string to ensure there are no further duplicates in
src/assets/translations/de-DE.json.
In `@src/assets/translations/en-US.json`:
- Around line 2659-2660: Remove the duplicate translation key
"Purchased/Redeemed Price" from the translations object so only one entry
remains; locate the two identical keys (both "Purchased/Redeemed Price") and
delete the redundant line, ensuring any value left is the intended one and that
no other duplicate keys for "Purchased/Redeemed Price" exist in the same object.
In `@src/assets/translations/es-CL.json`:
- Around line 2661-2662: The translation JSON contains a duplicate key
"Purchased/Redeemed Price"; remove the redundant entry so only one
"Purchased/Redeemed Price" mapping remains (keep the correct translation "Precio
comprado/canjeado"), ensuring the JSON stays valid and no other duplicate keys
exist for that symbol.
- Line 1641: The Spanish translation value for the key "Amount
Received/Returned" uses feminine agreement ("Monto recibida/devuelta"); update
the translation value to use masculine agreement "Monto recibido/devuelto" so it
matches the masculine noun "monto" (edit the string value for the "Amount
Received/Returned" JSON key).
In `@src/assets/translations/es-MX.json`:
- Around line 2655-2656: The JSON contains a duplicate key "Purchased/Redeemed
Price" — remove the redundant entry so the key appears only once, keeping the
existing value "Precio comprado/canjeado"; after removal, ensure the JSON
remains valid (no leftover trailing commas) and run the translations
linter/validator to confirm no other duplicates exist.
- Line 1643: The Spanish translation for the key "Amount Received/Returned" uses
incorrect gender agreement ("Monto recibida/devuelta"); update the value for the
key "Amount Received/Returned" in src/assets/translations/es-MX.json to a
grammatically correct masculine form such as "Monto recibido/devuelto" so both
adjectives agree with "Monto".
In `@src/assets/translations/fr-FR.json`:
- Around line 2664-2665: There are two identical JSON keys "Purchased/Redeemed
Price" in the translations which causes one entry to silently override the
other; remove the duplicate key so only one "Purchased/Redeemed Price" mapping
remains, preserve the correct French value ("Prix d'achat/de rachat") for the
kept entry, and ensure surrounding commas are adjusted so the JSON remains valid
(no trailing commas or missing separators).
In `@src/assets/translations/it-IT.json`:
- Line 2662: The file contains a duplicated translation key "Purchased/Redeemed
Price" in src/assets/translations/it-IT.json; remove the redundant entry so only
a single "Purchased/Redeemed Price": "Prezzo acquistato/riscattato" remains to
avoid ambiguous lookup behavior (keep whichever instance has correct surrounding
formatting/commas).
In `@src/assets/translations/ko-KO.json`:
- Around line 2662-2663: Remove the duplicate JSON key "Purchased/Redeemed
Price" in the ko-KO translation file: locate the repeated key
"Purchased/Redeemed Price" in src/assets/translations/ko-KO.json (entries around
the shown diff) and delete the redundant entry so only one "Purchased/Redeemed
Price": "구매/상환 가격" remains; also scan nearby entries to ensure no other
duplicate keys exist.
In `@src/assets/translations/lt-LT.json`:
- Around line 2660-2661: Remove the duplicate JSON key "Purchased/Redeemed
Price" in the lt-LT translation object so the key appears only once; locate both
occurrences of "Purchased/Redeemed Price" and delete the redundant entry,
leaving a single key/value pair with "Nupirkta/išpirkta kaina" (and ensure the
surrounding JSON still has valid commas/format after removal).
In `@src/assets/translations/lv-LV.json`:
- Around line 2661-2662: Remove the duplicate JSON entry for the key
"Purchased/Redeemed Price" so only a single mapping remains; locate both
occurrences of "Purchased/Redeemed Price" in the lv-LV.json translations and
delete one of them, ensuring the remaining entry preserves the intended value
and the file remains valid JSON (no extra commas or duplicate keys).
In `@src/assets/translations/ne-NE.json`:
- Around line 2660-2661: Remove the duplicate JSON key "Purchased/Redeemed
Price" from the translations JSON (leave exactly one entry for that key with the
value "खरिद गरिएको/रिडिम गरिएको मूल्य"), ensure the resulting file is valid JSON
(no trailing commas), and then run npx prettier --write . to reformat the file;
locate the duplicate by searching for the "Purchased/Redeemed Price" key in
src/assets/translations/ne-NE.json and delete the redundant line.
In `@src/assets/translations/pt-PT.json`:
- Around line 2660-2661: Remove the duplicated translation entry for the key
"Purchased/Redeemed Price": locate the two consecutive entries with that exact
key in the translations JSON and delete one of them so the key appears only once
(keep the correct value "Preço comprado/resgatado"); ensure the resulting JSON
remains valid (no trailing comma) and that only a single "Purchased/Redeemed
Price" key exists in pt-PT translations.
In `@src/assets/translations/sw-SW.json`:
- Around line 2658-2659: Remove the duplicate JSON key "Purchased/Redeemed
Price" so there is only one entry; locate both occurrences of the
"Purchased/Redeemed Price" key in the translations object, keep the intended
translation value (ensure it matches "Bei Iliyonunuliwa/Imekombolewa") and
delete the redundant line, then validate the JSON to ensure no trailing commas
or syntax errors remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 67b8c8ae-0b62-4f81-9035-6e1a1ff050c7
📒 Files selected for processing (15)
src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.htmlsrc/app/shares/shares-account-view/transactions-tab/transactions-tab.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
Mahesh-Gite-28
force-pushed
the
fix-share-transaction-typos
branch
from
f73e376 to
06a9cf1
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/assets/translations/es-MX.json (1)
1643-1643:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix gender agreement in the Spanish translation value.
Line 1643 uses feminine adjectives with a masculine noun (
Monto). Userecibido/devuelto.Suggested fix
- "Amount Received/Returned": "Monto recibida/devuelta", + "Amount Received/Returned": "Monto recibido/devuelto",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/assets/translations/es-MX.json` at line 1643, Update the Spanish translation value for the key "Amount Received/Returned" to use masculine agreement by replacing "Monto recibida/devuelta" with "Monto recibido/devuelto" so the adjectives agree with the masculine noun "Monto" in the translations JSON.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@src/assets/translations/es-MX.json`:
- Line 1643: Update the Spanish translation value for the key "Amount
Received/Returned" to use masculine agreement by replacing "Monto
recibida/devuelta" with "Monto recibido/devuelto" so the adjectives agree with
the masculine noun "Monto" in the translations JSON.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06d2f041-97dc-4d37-b0ff-e5cf77ba3300
📒 Files selected for processing (15)
src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.htmlsrc/app/shares/shares-account-view/transactions-tab/transactions-tab.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
✅ Files skipped from review due to trivial changes (4)
- src/assets/translations/lv-LV.json
- src/assets/translations/en-US.json
- src/assets/translations/pt-PT.json
- src/assets/translations/de-DE.json
|
Hi @Mahesh-Gite-28, kindly create a Jira ticket, as it is a mandatory part of the contribution process. Also, please go through the CONTRIBUTING.md guidelines before proceeding with the contribution. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/assets/translations/en-US.json`:
- Line 1: The file src/assets/translations/en-US.json needs formatting with the
repo's Prettier config; install the missing dependency
prettier-plugin-multiline-arrays (or run npm/yarn install) and then run the repo
formatter (npx prettier --write .) to fix formatting issues; ensure the JSON is
valid and unchanged semantically (verify the keys "Amount Received/Returned" and
"Purchased/Redeemed Price" remain present) and commit the resulting changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4108906d-42b8-4081-86d3-59e2a90c6ff1
📒 Files selected for processing (2)
src/assets/translations/en-US.jsonsrc/assets/translations/es-MX.json
|
@Mahesh-Gite-28 Please squash all your commits into a single commit before proceeding further. |
Mahesh-Gite-28
force-pushed
the
fix-share-transaction-typos
branch
from
fdd9b5a to
d83aa86
Compare
|
LGTM ✨ |
|
@Mahesh-Gite-28 Next time, before raising a PR, kindly create a Jira ticket first. |
Contributor
Author
|
Sure, noted. I’ll follow the Jira ticket and commit message conventions in future PRs. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes spelling typos in the Shares Account View transaction table and related translation keys.
Changes Made
Updated
transactions-tab.component.htmlFile:
src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.htmlChanges:
Purhcased→PurchasedRecieved→ReceivedamountRecievedOrReturned→amountReceivedOrReturnedUpdated
transactions-tab.component.tsFile:
src/app/shares/shares-account-view/transactions-tab/transactions-tab.component.tsChanges:
Updated column definition identifier:
amountRecievedOrReturned→amountReceivedOrReturnedUpdated Translation Files
Folder:
src/assets/translations/Changes:
Corrected translation key text:
Purhcased/Redeemed Price→Purchased/Redeemed PriceAmount Recieved/Returned→Amount Received/ReturnedAffected translation files:
cs-CS.jsonde-DE.jsonen-US.jsones-CL.jsones-MX.jsonfr-FR.jsonit-IT.jsonko-KO.jsonlt-LT.jsonlv-LV.jsonne-NE.jsonpt-PT.jsonsw-SW.jsonThese changes improve UI consistency and translation quality without affecting business logic.
Related issues and discussion
N/A
Screenshots, if any
N/A
Checklist
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit