Skip to content

Feat/rm update status cronjob and derive status instead#1032

Merged
jona159 merged 8 commits into
devfrom
feat/rm-update-status-cronjob-and-derive-status-instead
Jul 23, 2026
Merged

Feat/rm update status cronjob and derive status instead#1032
jona159 merged 8 commits into
devfrom
feat/rm-update-status-cronjob-and-derive-status-instead

Conversation

@jona159

@jona159 jona159 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.5% 2221 / 3290
🔵 Statements 65.96% 2295 / 3479
🔵 Functions 65.09% 429 / 659
🔵 Branches 51.77% 1064 / 2055
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/device.server.ts 63.75% 66.66% 61.7% 64.95% 86-91, 99, 205, 217-218, 287-302, 342, 376, 405, 434, 464, 468, 476-478, 484-486, 504-506, 510-512, 554-556, 571, 582-754, 805-809, 837-843, 848-864, 943-945, 956, 963-964, 972, 999, 1101-1121, 1140
app/db/models/sensor.server.ts 65.9% 66.66% 47.05% 67.44% 70-72, 128-133, 158-224, 278
app/db/schema/sensor.ts 87.5% 100% 80% 85.71% 50
app/lib/device-transform.ts 96% 92% 100% 100% 132
Generated in workflow #2804 for commit 2ccc1e4 by the Vitest Coverage Report Action

@scheidtdav scheidtdav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, is there anything missing thats keeping us from merging?
Any other reason this is a draft?

@jona159
jona159 marked this pull request as ready for review July 22, 2026 11:34
@jona159
jona159 merged commit 0486c69 into dev Jul 23, 2026
6 checks passed
@jona159
jona159 deleted the feat/rm-update-status-cronjob-and-derive-status-instead branch July 23, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants