nightly: drop Hermes variant (deprecated upstream) - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes the
hermesvariant from the nightly image channel. openab retiredHermes agent support and dropped it from all upstream CI in
openabdev/openab#1523 — the
pre-beta-hermesbase this channel builds FROM isno longer maintained, and the flaky installer fetch that motivated the
retirement lived in this lane too.
Changes
.github/workflows/nightly-images.ymlhermesremoved from both thebuildandmergematricesgithub_apihelper, theGH_TOKENenv (both existed only for Hermes'sauthenticated Contents API fetch), and the fail-closed
.nightly-hermes-install.shplaceholderCLI_REFplumbing removed end-to-end (resolver validation/output, bothbuild-argsblocks, smoke-test env) — Hermes was its only consumerDockerfile.nightlyhermes-installerscratch stage, its RUN bind-mount, thehermes)installcase, and the
CLI_REFARG removed.gitignore:.nightly-hermes-install.shentry removed (nightly-only artifact)Intentionally out of scope
image.yml(release channel) andNOTICEstill listhermes— the publishedpre-beta-hermes/beta-hermesbase tags still exist (frozen), so thatchannel keeps working for now. Removing it there is a separate decision.
Verification
hermes/CLI_REF/github_apireferences remain innightly-images.yml,Dockerfile.nightly,.gitignorenightly-images.ymlparses as valid YAMLpull_requestpaths trigger covers both changed files, so the matrix build + smoke test
run on this PR
Diffstat: 3 files, +5 / −86.